Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make clean on mac fails to cleanup *.dSYM directories #2215

Closed
tedhorst opened this issue Apr 15, 2012 · 4 comments
Closed

make clean on mac fails to cleanup *.dSYM directories #2215

tedhorst opened this issue Apr 15, 2012 · 4 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@tedhorst
Copy link
Contributor

Lots of errors like:
@boggle
Copy link
Contributor

boggle commented Apr 15, 2012

Yep, I get those, too.

@jdm
Copy link
Contributor

jdm commented Apr 15, 2012

@brson can you think of any reasons not to change the rm lines to use -rf?

@brson
Copy link
Contributor

brson commented Apr 15, 2012

@jdm nope, but let's limit the -R to just dSYMs

@tedhorst tedhorst mentioned this issue Apr 17, 2012
Merged
@brson
Copy link
Contributor

brson commented Apr 17, 2012

Fixt

@brson brson closed this as completed Apr 17, 2012
bors added a commit to rust-lang-ci/rust that referenced this issue Sep 22, 2022
@bors
Auto merge of rust-lang#2215 - InfRandomness:getpid_shim, r=RalfJung
c5f7a7d 
Getpid shim
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@qinheping
RFC: Loop-contract synthesis (rust-lang#2215)
2a306ab
RalfJung pushed a commit to RalfJung/rust that referenced this issue Jun 29, 2024
@bors
Auto merge of rust-lang#3716 - cgettys-microsoft:dev/cgettys/process_…
9c21872 
…id_fixup-03, r=RalfJung

Remove GetCurrentProcessId's frame_in_std check

Most of the support required to close rust-lang#1727 was actually added a while back, in rust-lang#2215.

However, for some reason, even though the Unix/Linux syscall equivalent has no `frame_in_std()` check, the Windows `GetCurrentProcessId` check did. While the vast majority of use cases use `std::process::id`, there's no particular reason to penalize any Windows code that is no_std or for whatever other reason choses to call the function directly (e.g. via the generated [windows-sys](https://docs.rs/windows-sys/latest/windows_sys/Win32/System/Threading/fn.GetCurrentProcessId.html) method). The emulation should still work fine. Given there's no reason not to, we might as well simplify the code a tiny bit and save that branch / frame check during runtime too.

This PR removes the `frame_in_std` restriction for `GetCurrentProcessId`, and also moves it into the environment related shim section per discussion in rust-lang/miri#1727 (comment).

Still passes existing tests/pass/getpid.rs test.

Closes rust-lang#1727 unless we wish to give a dummy value when isolated, which we don't seem to want to do at this time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jdm @boggle @tedhorst @brson