rustdoc trait implementations should be collapsible #24483
Comments
alexcrichton
added
the
T-rustdoc
|
Hmm this is a bit tricky. If you want to collapse to search for a fn, this will hide some of the fns. If it's on a trait that you don't know about you might never find it. I suppose you could toss a bulk-collapse on top of the "traits". Or perhaps double-clicking collapse "super collapses" everything. |
|
Why not just search for the trait? Each trait lists all the functions it supports anyway. |
|
That requires you to know that it's a trait being invoked. This is perhaps unrealistic; they'll probably search for the fn in the global search. |
|
I see how this could be problematic. |
|
I still think this has potential. I'd suggest basically making the "super collapse" buttons step-wise: lvl 0: show everything
|
|
I wonder about clicking the [EDIT] |
|
Triage: no change |
steveklabnik
added
T-dev-tools
Mark-Simulacrum
added
the
C-feature-request
Addresses rust-lang#40363, rust-lang#45720, rust-lang#24483, rust-lang#23986 and so on * Expands and refactors collapseDocs and toggleAllDocs * Adds [-] toggle to all impls (including inherent impl) * Makes it hiding though main css file, not though element style May need to be addressed: * "[-]" and anchor link copier are overlaid a bit * Inherent methods are also hidden by the global [-] toggle. * Auto-collapsing "Iterator" and so on by default is not implemented yet * Tested only shallowly and only in Chromiuim * No tests. Are there tests for css/js part here? * The new implementation may be a bit slower.
…umeGomez,QuietMisdreavus rustdoc: Foldable impl blocks Addresses rust-lang#40363, rust-lang#45720, rust-lang#24483, rust-lang#23986 and so on * Expands and refactors collapseDocs and toggleAllDocs * Adds [-] toggle to all impls (including inherent impl) * Makes it hiding though main css file, not though element inline style May need to be addressed: * "[-]" and anchor link copier are overlaid a bit * Inherent methods are also hidden by the global [-] toggle. * Auto-collapsing "Iterator" and so on by default is not implemented yet * Tested only shallowly and only in Chromiuim * No tests. Are there tests for css/js part here? * The new implementation may be a bit slower. What next steps are need to be done before the integration?
…ietMisdreavus rustdoc: Foldable impl blocks Addresses #40363, #45720, #24483, #23986 and so on * Expands and refactors collapseDocs and toggleAllDocs * Adds [-] toggle to all impls (including inherent impl) * Makes it hiding though main css file, not though element inline style May need to be addressed: * "[-]" and anchor link copier are overlaid a bit * Inherent methods are also hidden by the global [-] toggle. * Auto-collapsing "Iterator" and so on by default is not implemented yet * Tested only shallowly and only in Chromiuim * No tests. Are there tests for css/js part here? * The new implementation may be a bit slower. What next steps are need to be done before the integration?
|
Fixed by #47894. |
Pages like vec are very repetitive, especially when arrays are involved.It'd be nice if collapse all collapsed the methods inside the
Trait Implementationsimpl'sThe text was updated successfully, but these errors were encountered: