Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc should accept rustc -O -C opt-level=x #32352

Closed
bluss opened this issue Mar 19, 2016 · 1 comment · Fixed by #60426
Closed

rustc should accept rustc -O -C opt-level=x #32352

bluss opened this issue Mar 19, 2016 · 1 comment · Fixed by #60426
Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@bluss
Copy link
Member

bluss commented Mar 19, 2016

rustc -O -O is ok just like rustc -C opt-level=1 -C opt-level=2. -O is documented to be the same as -C opt-level=2, so there should be no conflict, just have the last argument take precedent.

-g vs -C debuginfo=2 behave the same way.

$ rustc -O -C opt-level=2
error: -O and -C opt-level both provided

$ rustc -C opt-level=1 -C opt-level=2 -g -g foo.rs
# ok.
@sanxiyn sanxiyn mentioned this issue Mar 21, 2016
Closed
@sanxiyn sanxiyn mentioned this issue May 8, 2016
Closed
@steveklabnik steveklabnik added A-frontend Area: Compiler frontend (errors, parsing and HIR) C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Jul 25, 2016
@steveklabnik
Copy link
Member

Triage: no change

This was referenced Apr 27, 2019
Merged
Merged
Merged
bors added a commit that referenced this issue May 3, 2019
@bors
Auto merge of #60423 - varkor:update-getopts, r=alexcrichton
ef9a876 
Update getopts

This is a prerequisite to fixing #32352. The rustbuild fix has been pulled out of #59440.

r? @alexcrichton
Centril added a commit to Centril/rust that referenced this issue May 3, 2019
@Centril
Rollup merge of rust-lang#60426 - varkor:fix-duplicate-arg-handling, …
16f7531 
…r=alexcrichton

Stop `-O`/`-C opt-level` and `-g`/`-C debuginfo` conflicting

Allow `-O` and `-C opt-level`, and `-g` and `-C debuginfo` to be specified simultaneously without conflict. In such cases, the rightmost provided option is chosen.

Fixes rust-lang#7493.
Fixes rust-lang#32352.

~Blocked on rust-lang/getopts#79

r? @alexcrichton
bors added a commit that referenced this issue May 4, 2019
@bors
Auto merge of #60426 - varkor:fix-duplicate-arg-handling, r=alexcrichton
9387d18 
Stop `-O`/`-C opt-level` and `-g`/`-C debuginfo` conflicting

Allow `-O` and `-C opt-level`, and `-g` and `-C debuginfo` to be specified simultaneously without conflict. In such cases, the rightmost provided option is chosen.

Fixes #7493.
Fixes #32352.

~Blocked on rust-lang/getopts#79

r? @alexcrichton
Manishearth added a commit to Manishearth/rust that referenced this issue May 5, 2019
@Manishearth
Rollup merge of rust-lang#60426 - varkor:fix-duplicate-arg-handling, …
a8ed677 
…r=alexcrichton

Stop `-O`/`-C opt-level` and `-g`/`-C debuginfo` conflicting

Allow `-O` and `-C opt-level`, and `-g` and `-C debuginfo` to be specified simultaneously without conflict. In such cases, the rightmost provided option is chosen.

Fixes rust-lang#7493.
Fixes rust-lang#32352.

~Blocked on rust-lang/getopts#79

r? @alexcrichton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop -O/-C opt-level and -g/-C debuginfo conflicting varkor/rust
2 participants
@steveklabnik @bluss