Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E0046 needs to be updated to new format #35209

Closed
sophiajt opened this issue Aug 2, 2016 · 3 comments
Closed

E0046 needs to be updated to new format #35209

sophiajt opened this issue Aug 2, 2016 · 3 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 2, 2016 •
edited
Loading

From: src/test/compile-fail/E0046.rs

Error E0046 needs a span_label, updating it from:

error[E0046]: not all trait items implemented, missing: `foo`
  --> src/test/compile-fail/E0046.rs:17:1
   |
17 | impl Foo for Bar {} //~ ERROR E0046
   | ^^^^^^^^^^^^^^^^^^^

To:

error[E0046]: not all trait items implemented, missing: `foo`
  --> src/test/compile-fail/E0046.rs:17:1
   |
17 | impl Foo for Bar {} //~ ERROR E0046
   | ^^^^^^^^^^^^^^^^^^^ missing `foo` in implementation
@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 2, 2016
@GuillaumeGomez GuillaumeGomez mentioned this issue Aug 3, 2016
Closed
@shri3k shri3k mentioned this issue Aug 5, 2016
Merged
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 7, 2016
Rollup merge of rust-lang#35355 - shri3k:E0046, r=jonathandturner
31f0204 
Updates compiler error E0046 with new format

Addresses rust-lang#35209 as part of rust-lang#35233.
r? @jonathandturner

I've repeated the following in my code. If this is something not desirable then let me know if there's any process to make this any cleaner. Thank you.
```rust
missing_items.iter()
    .map(|name| name.to_string())
     .collect::<Vec<_>>().join("`, `"))
```
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 7, 2016
Rollup merge of rust-lang#35355 - shri3k:E0046, r=jonathandturner
ee5b2df 
Updates compiler error E0046 with new format

Addresses rust-lang#35209 as part of rust-lang#35233.
r? @jonathandturner

I've repeated the following in my code. If this is something not desirable then let me know if there's any process to make this any cleaner. Thank you.
```rust
missing_items.iter()
    .map(|name| name.to_string())
     .collect::<Vec<_>>().join("`, `"))
```
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 7, 2016
Rollup merge of rust-lang#35355 - shri3k:E0046, r=jonathandturner
0b567c6 
Updates compiler error E0046 with new format

Addresses rust-lang#35209 as part of rust-lang#35233.
r? @jonathandturner

I've repeated the following in my code. If this is something not desirable then let me know if there's any process to make this any cleaner. Thank you.
```rust
missing_items.iter()
    .map(|name| name.to_string())
     .collect::<Vec<_>>().join("`, `"))
```
@KiChjang
Copy link
Member

KiChjang commented Aug 8, 2016

Should be fixed by #35355.

@kali
Copy link
Contributor

kali commented Sep 16, 2016

Not sure if this is the right place, but it would be great if the error message was giving the whole prototype of the missing methods, ready to be cut-and-pasted (scalac does it).

@sophiajt
Copy link
Contributor Author

@kali - can you file a new issue with your suggestion and cc me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kali @sophiajt @KiChjang