Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libsyntax not in 1.20 nightly rust-src component? #42667

Closed
brson opened this issue Jun 15, 2017 · 7 comments
Closed

libsyntax not in 1.20 nightly rust-src component? #42667

brson opened this issue Jun 15, 2017 · 7 comments
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. P-low Low priority T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@brson
Copy link
Contributor

brson commented Jun 15, 2017

Per a rustup report, are the nightly rust-src packages not including libsyntax?
@brson brson added the regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. label Jun 15, 2017
@brson brson mentioned this issue Jun 15, 2017
Closed
@brson
Copy link
Contributor Author

brson commented Jun 15, 2017

cc @gbip

@ishitatsuyuki
Copy link
Contributor

Yes, since they're rustc source, and only libstd source is needed for racer.

Blame #41546

@brson brson added I-needs-decision Issue: In need of a decision. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. P-high High priority labels Jun 15, 2017
@brson brson self-assigned this Jun 15, 2017
@nrc nrc removed the I-needs-decision Issue: In need of a decision. label Jun 19, 2017
@nrc
Copy link
Member

nrc commented Jun 19, 2017

We discussed at the dev-tools meeting today, consensus was that this is by design and the decision to remove was good

@nrc
Copy link
Member

nrc commented Jun 19, 2017

Further, we thought that for users who want the compiler sources, we should make available a separate rust-src-internals with the source for the compiler including libsyntax.

@nrc nrc added P-low Low priority and removed P-high High priority labels Jun 19, 2017
@alexcrichton
Copy link
Member

Untagging as a regression due to previous comment

@alexcrichton alexcrichton removed the regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. label Jul 23, 2017
@Mark-Simulacrum Mark-Simulacrum added C-bug Category: This is a bug. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) and removed T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. labels Jul 27, 2017
@tnielens tnielens mentioned this issue Aug 11, 2017
Open
@dwrensha dwrensha mentioned this issue Sep 9, 2017
Closed
@Mark-Simulacrum Mark-Simulacrum added C-feature-request Category: A feature request, i.e: not implemented / a PR. and removed C-bug Category: This is a bug. labels Sep 15, 2017
@ishitatsuyuki ishitatsuyuki mentioned this issue Feb 11, 2019
Closed
@sanmai-NL
Copy link

@alexcrichton: can this be closed?

@oli-obk
Copy link
Contributor

oli-obk commented Mar 18, 2019

fixed in #58269

@oli-obk oli-obk closed this as completed Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. P-low Low priority T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@alexcrichton @brson @oli-obk @nrc @sanmai-NL @Mark-Simulacrum @ishitatsuyuki