Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: mismatched types #70444

Closed
Mark-Simulacrum opened this issue Mar 26, 2020 · 3 comments
Closed

regression: mismatched types #70444

Mark-Simulacrum opened this issue Mar 26, 2020 · 3 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Mark-Simulacrum
Copy link
Member

https://crater-reports.s3.amazonaws.com/beta-1.43-1/beta-2020-03-12/gh/finegeometer.vector-spaces-rs/log.txt

It looks like type parameter order got switched somewhere somehow, though I am unclear how that managed to happen. Possibly related to recent inference work to make binary operators work for references?
@Mark-Simulacrum Mark-Simulacrum added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Mar 26, 2020
@Mark-Simulacrum
Copy link
Member Author

Also leaving https://crater-reports.s3.amazonaws.com/beta-1.43-1/beta-2020-03-12/reg/yass-aux-0.1.1/log.txt here in case it's the same underlying bug (looks quite similar at a high level) but we should file a separate issue if not.

@Mark-Simulacrum
Copy link
Member Author

cc @Aaron1011 who I think has done some inference related work recently

@Mark-Simulacrum Mark-Simulacrum mentioned this issue Mar 26, 2020
Closed
@Centril
Copy link
Contributor

Centril commented Mar 26, 2020

Closing as expected fallout from #69340 and wontfix.

#70444 (comment) might be unrelated though.

@Centril Centril closed this as completed Mar 26, 2020
@Mark-Simulacrum Mark-Simulacrum mentioned this issue Mar 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Centril @Mark-Simulacrum