Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 4 pull requests #100644

Merged
merged 12 commits into from
Aug 16, 2022
Merged

Rollup of 4 pull requests #100644

merged 12 commits into from
Aug 16, 2022

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Aug 16, 2022

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

kckeiks and others added 12 commits August 15, 2022 13:49
Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com>
…tem, r=cjgillot

Remove opt_remap_env_constness from rustc_query_impl

1st task off rust-lang#96524.

r? `@cjgillot`
…thomcc

Add `IpDisplayBuffer` helper struct.

This removes the dependency on `std::io::Write` for implementing `Display`, allowing it to be moved to `core` as proposed in rust-lang/rfcs#2832.
…er-errors

Use `merged_ty` method instead of rewriting it every time

`merged_ty` [source code](https://doc.rust-lang.org/nightly/nightly-rustc/src/rustc_typeck/check/coercion.rs.html#1331-1333) is quite literally the same, so instead of rewriting it, makes more sense to use the method instead.

r? `@compiler-errors`
…f, r=GuillaumeGomez

rustdoc JSON: Fix ICE with `pub extern crate self as <self_crate_name>`

Closes rust-lang#100531

r? `@GuillaumeGomez`

`@rustbot` labels +A-rustdoc-json +T-rustdoc
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Aug 16, 2022
@TaKO8Ki
Copy link
Member Author

TaKO8Ki commented Aug 16, 2022

@bors r+ rollup=never p=4

@bors
Copy link
Contributor

bors commented Aug 16, 2022

📌 Commit af74e72 has been approved by TaKO8Ki

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 16, 2022
@bors
Copy link
Contributor

bors commented Aug 16, 2022

⌛ Testing commit af74e72 with merge 86c6ebe...

@bors
Copy link
Contributor

bors commented Aug 16, 2022

☀️ Test successful - checks-actions
Approved by: TaKO8Ki
Pushing 86c6ebe to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 16, 2022
@bors bors merged commit 86c6ebe into rust-lang:master Aug 16, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 16, 2022
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Perf Build Sha
#100630 b6fd7d73d632261b187da51e93073dfc2fb21009
#100629 fef826266090dfec0c37e4cffb5163a2c48cbc2a
#100625 fe480d7a6216cb9ecd3522e71aa3b95d70abfa1d
#100243 593c22b8fa6503889d808c3e40f1e63d74d64a09

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (86c6ebe): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: ✅ relevant improvement found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.6% 3.7% 6
Improvements ✅
(primary)
-2.9% -2.9% 1
Improvements ✅
(secondary)
-1.7% -1.7% 2
All ❌✅ (primary) -2.9% -2.9% 1

Cycles

Results
  • Primary benchmarks: ✅ relevant improvements found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.9% -3.2% 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.9% -3.2% 2

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change 2

  2. number of relevant changes 2

@TaKO8Ki TaKO8Ki deleted the rollup-n0o6a1t branch August 17, 2022 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants