Implement size_hint for Range
#10416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Blocked on #8605 Need numeric trait for converting to `Option<uint>` | ||
| #[inline] | ||
| fn size_hint(&self) -> (uint, Option<uint>) { | ||
| match self.state.to_uint() { |
There was a problem hiding this comment.
let opt_bound = do self.state.to_uint().and_then |a| {
do self.stop.to_uint().map(|b| b - a);
};
opt_bound.map_default((uint::max_value, None), |bound| (bound, Some(bound)))maybe?
Also, what happens if b - a wraps? (Is it possible with a sane type A?)
There was a problem hiding this comment.
Oh, also, what about range(-10i, -1i).size_hint()? Won't this give uint::max_value as the lower bound, incorrectly?
bors
added a commit
that referenced
this pull request
Nov 11, 2013
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 30, 2023
…shearth Extend `explicit_iter_loop` and `explicit_into_iter_loop` fixes rust-lang#1518 Some included cleanups * Split `for_loop` test into different files for each lint (partially). * Move handling of some `into_iter` cases from `explicit_into_iter`. --- changelog: Enhancement: [`explicit_iter_loop`]: Now also handles types that implement `IntoIterator`. [rust-lang#10416](rust-lang/rust-clippy#10416) changelog: Sugg: [`explicit_into_iter_loop`]: The suggestion now works on mutable references. [rust-lang#10416](rust-lang/rust-clippy#10416) <!-- changelog_checked -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.