Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #105667

Merged
merged 36 commits into from
Dec 14, 2022
Merged

Rollup of 7 pull requests #105667

merged 36 commits into from
Dec 14, 2022

Commits on Dec 8, 2022

  1. Configuration menu
    Copy the full SHA
    0c0fb22 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6275b04 View commit details
    Browse the repository at this point in the history
  3. Bless incremental tests

    nbdd0121 committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    3c0983c View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2022

  1. Fix typo

    spastorino committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    8937720 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b0c3228 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. Allow unsafe through inline const

    This is handled similar to closures
    nbdd0121 committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    9342d1e View commit details
    Browse the repository at this point in the history
  2. Allow unsafe through inline const for THIR unsafety checker

    The closure handling code is changed slightly to avoid allocation
    when THIR building failed.
    nbdd0121 committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    aa5af2a View commit details
    Browse the repository at this point in the history
  3. Add tests

    nbdd0121 committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    f03c2ae View commit details
    Browse the repository at this point in the history
  4. Ensure valid local_data is set for custom mir building

    MIR unsafety checking requires this to be valid
    nbdd0121 committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    adf1717 View commit details
    Browse the repository at this point in the history
  5. Remove unnecessary recursive call to parent unsafeck

    All bodies are unsafe checked anyway. Current MIR unsafeck also just
    returns for closures.
    nbdd0121 committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    5c58a1b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d2830cb View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d6dc912 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a8a4510 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    cb26b35 View commit details
    Browse the repository at this point in the history
  10. Inform the user which trait is meant in the diagnostic itself instead…

    … of relying on the span making it obvious
    oli-obk committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    717294f View commit details
    Browse the repository at this point in the history
  11. Clarify what "this" means

    oli-obk committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    063b167 View commit details
    Browse the repository at this point in the history
  12. Don't emit empty notes

    oli-obk committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    2e2a479 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    59554a2 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    6984085 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    1f5cb9e View commit details
    Browse the repository at this point in the history
  16. bless fulldeps tests

    oli-obk committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    82ce70a View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    3522d48 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    4ae0c55 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    b22769a View commit details
    Browse the repository at this point in the history
  20. Change pattern borrowing suggestions to be verbose

    Synthesize a more accurate span and use verbose suggestion output to
    make the message clearer.
    estebank committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    e46416e View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    4f7c257 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    dd72b1a View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    b8bd1d0 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    cf0b6b9 View commit details
    Browse the repository at this point in the history
  25. Rollup merge of rust-lang#105147 - nbdd0121:inline_const_unsafe, r=ol…

    …i-obk
    
    Allow unsafe through inline const
    
    Handle similar to closures.
    
    Address rust-lang#104087 (comment)
    
    Note that this PR does not fix the issue for `unsafe { [0; function_requiring_unsafe()] }`. This is fundamentally unfixable for MIR unsafeck IMO.
    
    This PR also does not fix unsafety checking for inline const in pattern position. It actually breaks it, allowing unsafe functions to be used in inline const in pattern position without unsafe blocks. Inline const in pattern position is not visible in MIR so ignored by MIR unsafety checking (currently it is also not checked by borrow checker, which is the reason why it's considered an incomplete feature).
    
    `@rustbot` label: +T-lang +F-inline_const
    matthiaskrgr authored Dec 13, 2022
    Configuration menu
    Copy the full SHA
    7357cfb View commit details
    Browse the repository at this point in the history
  26. Rollup merge of rust-lang#105438 - compiler-errors:move-methods, r=es…

    …tebank
    
    Move some codegen-y methods from `rustc_hir_analysis::collect` -> `rustc_codegen_ssa`
    
    Unclear if they should live here, but they seem codegen-y enough, and `rustc_hir_analysis::collect` is extremely long, so it should probably lose some methods.
    matthiaskrgr authored Dec 13, 2022
    Configuration menu
    Copy the full SHA
    51375dd View commit details
    Browse the repository at this point in the history
  27. Rollup merge of rust-lang#105464 - nbdd0121:hir, r=compiler-errors

    Support #[track_caller] on async closures
    
    Follow up on rust-lang#105180
    
    r? ```@compiler-errors```
    cc ```@cjgillot```
    matthiaskrgr authored Dec 13, 2022
    Configuration menu
    Copy the full SHA
    5e38e70 View commit details
    Browse the repository at this point in the history
  28. Rollup merge of rust-lang#105476 - estebank:moves-n-borrows, r=compil…

    …er-errors
    
    Change pattern borrowing suggestions to be verbose and remove invalid suggestion
    
    Synthesize a more accurate span and use verbose suggestion output to
    make the message clearer.
    
    Do not suggest borrowing binding in pattern in let else. Fix rust-lang#104838.
    matthiaskrgr authored Dec 13, 2022
    Configuration menu
    Copy the full SHA
    dcdbbd0 View commit details
    Browse the repository at this point in the history
  29. Rollup merge of rust-lang#105500 - oli-obk:unhide_unknown_spans, r=es…

    …tebank
    
    Make some diagnostics not depend on the source of what they reference being available
    
    r? `@estebank`
    
    follow up to rust-lang#104449
    matthiaskrgr authored Dec 13, 2022
    Configuration menu
    Copy the full SHA
    15b9e20 View commit details
    Browse the repository at this point in the history
  30. Rollup merge of rust-lang#105628 - spastorino:small-doc-fixes, r=comp…

    …iler-errors
    
    Small doc fixes
    
    r? `@compiler-errors`
    matthiaskrgr authored Dec 13, 2022
    Configuration menu
    Copy the full SHA
    1c86de2 View commit details
    Browse the repository at this point in the history
  31. Rollup merge of rust-lang#105659 - JakobDegen:storage-live-borrow, r=…

    …davidtwco
    
    Don't require owned data in `MaybeStorageLive`
    
    Small improvement that avoids a clone. I don't expect this to have any noticeable perf effects, but better to have it than not to.
    
    r? ``@tmiasko``
    matthiaskrgr authored Dec 13, 2022
    Configuration menu
    Copy the full SHA
    e0e9f3a View commit details
    Browse the repository at this point in the history