Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't bug if we're trying to cast dyn* to another type #105710

Merged
merged 1 commit into from
Dec 17, 2022
Merged

Don't bug if we're trying to cast dyn* to another type #105710

merged 1 commit into from
Dec 17, 2022

Conversation

compiler-errors
Copy link
Member

Fixes #105097

@rustbot
Copy link
Collaborator

rustbot commented Dec 14, 2022

r? @eholk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 14, 2022
@eholk
Copy link
Contributor

eholk commented Dec 16, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Dec 16, 2022

📌 Commit d0db327 has been approved by eholk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 16, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 17, 2022
@bors
Auto merge of rust-lang#105804 - matthiaskrgr:rollup-iaqlbl3, r=matth…
998e1a9 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#105493 (Help rust-analyzer normalize query return types)
 - rust-lang#105710 (Don't bug if we're trying to cast `dyn*` to another type)
 - rust-lang#105711 (bail in `collect_trait_impl_trait_tys` if signatures reference errors)
 - rust-lang#105768 (Detect inherent associated types not having CamelCase)
 - rust-lang#105780 (rustdoc: Don't add "Read more" link if there is no extra content)
 - rust-lang#105802 (Make enum-match.rs test robust against variable name changes)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 86bbc20 into rust-lang:master Dec 17, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 17, 2022
@compiler-errors compiler-errors deleted the dyn-star-rigid-cast branch August 11, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eholk eholk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.

ICE with dyn_star: should be handled by try_coerce
4 participants
@compiler-errors @rustbot @eholk @bors