Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI test for documentation of hidden items in std #105794

Merged
merged 2 commits into from
Dec 17, 2022

Conversation

ChrisDenton
Copy link
Member

Fixes #87844

r? @jyn514

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 16, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 16, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@jyn514
Copy link
Member

jyn514 commented Dec 16, 2022

@ChrisDenton docker seems to be messing with the quotes.

; cat Dockerfile 
FROM alpine:latest
ENV SCRIPT RUSTDOCFLAGS="--document-private-items --document-hidden-items" env | grep RUSTDOC
RUN sh -c "$SCRIPT"
; docker build .
Sending build context to Docker daemon  79.49MB
Step 1/3 : FROM alpine:latest
 ---> 49176f190c7e
Step 2/3 : ENV SCRIPT RUSTDOCFLAGS="--document-private-items --document-hidden-items" env | grep RUSTDOC
 ---> Using cache
 ---> cb827fc459ad
Step 3/3 : RUN sh -c "$SCRIPT"
 ---> Running in 94860e857d3b
sh: --document-hidden-items: not found
The command '/bin/sh -c sh -c "$SCRIPT"' returned a non-zero code: 1

@jyn514
Copy link
Member

jyn514 commented Dec 16, 2022

Escaping the backslashes seems to work:

; docker build .
Sending build context to Docker daemon  79.49MB
Step 1/3 : FROM alpine:latest
 ---> 49176f190c7e
Step 2/3 : ENV SCRIPT RUSTDOCFLAGS=\"--document-private-items --document-hidden-items\" env
 ---> Running in bd1af3f1d278
Removing intermediate container bd1af3f1d278
 ---> efaf4a9fafd7
Step 3/3 : RUN sh -c "$SCRIPT"
 ---> Running in c07667c971ce
RUSTDOCFLAGS=--document-private-items --document-hidden-items
SCRIPT=RUSTDOCFLAGS="--document-private-items --document-hidden-items" env

@ChrisDenton
Copy link
Member Author

Oh eck. Fixed.

@jyn514
Copy link
Member

jyn514 commented Dec 16, 2022

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Dec 16, 2022

📌 Commit 8534fd3 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2022
@bors
Copy link
Contributor

bors commented Dec 17, 2022

⌛ Testing commit 8534fd3 with merge fde3000...

@bors
Copy link
Contributor

bors commented Dec 17, 2022

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing fde3000 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 17, 2022
@bors bors merged commit fde3000 into rust-lang:master Dec 17, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 17, 2022
@ChrisDenton ChrisDenton deleted the internal-doc branch December 17, 2022 09:09
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (fde3000): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.6% [2.6%, 2.6%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.0% [-5.8%, -2.2%] 3
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI tests running rustdoc with --document-private-items --document-hidden-items on std?
5 participants