Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the documentation of Vec to use extend(array) instead of extend(array.iter().copied()) #106187

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Update the documentation of Vec to use extend(array) instead of extend(array.iter().copied()) #106187

merged 1 commit into from
Dec 28, 2022

Conversation

ChayimFriedman2
Copy link
Contributor

@ChayimFriedman2 ChayimFriedman2 commented Dec 27, 2022 •
edited
Loading

Another option is to use extend_from_slice() (that may be faster), but I find this approach cleaner.

@rustbot
Copy link
Collaborator

rustbot commented Dec 27, 2022

r? @m-ou-se

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 27, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 27, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@compiler-errors
Copy link
Member

Thanks, seems like a short documentation change so I'll approve.

r? @compiler-errors @bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 27, 2022

📌 Commit 4df5459 has been approved by compiler-errors

It is now in the queue for this repository.

@rustbot rustbot assigned compiler-errors and unassigned m-ou-se Dec 27, 2022
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2022
@compiler-errors compiler-errors mentioned this pull request Dec 27, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 27, 2022
@bors
Auto merge of rust-lang#106193 - compiler-errors:rollup-0l54wka, r=co…
739d68a 
…mpiler-errors

Rollup of 9 pull requests

Successful merges:

 - rust-lang#103718 (More inference-friendly API for lazy)
 - rust-lang#105765 (Detect likely `.` -> `..` typo in method calls)
 - rust-lang#105852 (Suggest rewriting a malformed hex literal if we expect a float)
 - rust-lang#105965 (Provide local extern function arg names)
 - rust-lang#106064 (Partially fix `explicit_outlives_requirements` lint in macros)
 - rust-lang#106179 (Fix a formatting error in Iterator::for_each docs)
 - rust-lang#106181 (Fix doc comment parsing description in book)
 - rust-lang#106187 (Update the documentation of `Vec` to use `extend(array)` instead of `extend(array.iter().copied())`)
 - rust-lang#106189 (Fix UnsafeCell Documentation Spelling Error)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 79730d6 into rust-lang:master Dec 28, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 28, 2022
@ChayimFriedman2 ChayimFriedman2 deleted the patch-4 branch August 4, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ChayimFriedman2 @rustbot @compiler-errors @bors @m-ou-se