Add sanitizer support for modern iOS platforms

[keith]

asan and tsan generally support iOS, but that previously wasn't configured in rust. This only adds support for the simulator architectures, and arm64 device architecture, not the older 32 bit architectures.

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

[rustbot]

These commits modify compiler targets.
(See the Target Tier Policy.)

[keith]

This is required because sanitizers are built with the -U linker flag, which isn't compatible with bitcode. The sanitizers shipped in Xcode also don't have bitcode, and theoretically that shouldn't ever matter since on iOS folks don't ship sanitizers to prod. This wouldn't be necessary if bitcode was dropped entirely now that Xcode 14 deprecated it and Apple no longer accepts apps with it, see rust-lang/cc-rs#768

[bors]

☔ The latest upstream changes (presumably #106429) made this pull request unmergeable. Please resolve the merge conflicts.

[Mark-Simulacrum]

cc @deg4uss3r

r? @badboy

(Not quite for ios, but seems like there might be more context in iOS simulator target maintainers)

[badboy]

Neat. So far I never even tried to reach for the sanitizers, but if it's that easy to allow them I don't see why not.
I won't have time to actually try this before next week, but that shouldn't block this PR.

If this only affects sanitizer builds then I see no problem.

[deg4uss3r]

Agreed with @badboy sorry for the late response, behind on OSS work :/

[apiraino]

Hello, checking progress: what's the status? is this still waiting on a review or maybe waiting for an official r+ (see comment)?

[badboy]

@bors r+

[bors]

📌 Commit df4b929cef1ada5b7f1cd90ddc4939e2bc0896b1 has been approved by badboy

It is now in the queue for this repository.

[badboy]

Apparently I can approve it, so I did.

[bors]

⌛ Testing commit df4b929cef1ada5b7f1cd90ddc4939e2bc0896b1 with merge 1cc58a85fde9aab9f56340bdd4c254d17760fbd8...

[bors]

💔 Test failed - checks-actions

[keith]

Hoping to have fixed the CI issue here, I was passing -fembed-bitcode=off always which was invalid in some linux case, now I only do this if apple is in the target

[badboy]

@bors r+

[bors]

📌 Commit aacf321 has been approved by badboy

It is now in the queue for this repository.

[bors]

⌛ Testing commit aacf321 with merge 6d819a4...

[bors]

☀️ Test successful - checks-actions
Approved by: badboy
Pushing 6d819a4 to master...

[rust-timer]

Finished benchmarking commit (6d819a4): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.3%, 0.3%]	2
Regressions ❌ (secondary)	1.2%	[1.2%, 1.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[0.3%, 0.3%]	2

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.4%, -2.2%]	2
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.7%	[-6.5%, -4.9%]	6
All ❌✅ (primary)	-	-	0