Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: remove unused fn parameter tab #107852

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

notriddle
Copy link
Contributor

No description provided.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 9, 2023
@GuillaumeGomez
Copy link
Member

Nice catch, thanks! How did you find it btw?

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 9, 2023

📌 Commit 792b846 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 9, 2023
@notriddle
Copy link
Contributor Author

I didn't really have a structured search method. I just used the rust-analyzer to find all the places the function was called, and this function was only called in one place.

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 10, 2023
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#107043 (Support `true` and `false` as boolean flag params)
 - rust-lang#107831 (Query refactoring)
 - rust-lang#107841 (Handled snap curl issue inside Rust)
 - rust-lang#107852 (rustdoc: remove unused fn parameter `tab`)
 - rust-lang#107861 (Sync release notes for 1.67.1)
 - rust-lang#107863 (Allow multiple candidates with same response in new solver)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d4d1c93 into rust-lang:master Feb 10, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 10, 2023
@notriddle notriddle deleted the notriddle/rm-tab branch February 10, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants