Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating rustc_infer to session diagnostics (part 5) #108698

Merged
merged 16 commits into from
Apr 10, 2023
Merged

Migrating rustc_infer to session diagnostics (part 5) #108698

merged 16 commits into from
Apr 10, 2023

Commits on Apr 4, 2023

  1. Ported FunctionPointerSuggestion

    @IntQuant
    IntQuant committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    37f5569 View commit details
    Browse the repository at this point in the history

  2. Migrate SuggestAsRefWhereAppropriate

    @IntQuant
    IntQuant committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    b36abea View commit details
    Browse the repository at this point in the history

  3. Migrate SuggestAccessingField

    @IntQuant
    IntQuant committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    d56b304 View commit details
    Browse the repository at this point in the history

  4. Migrate SuggestBoxingForReturnImplTrait, Fix typo in infer_fn_conside… 

    …r_casting
    @IntQuant
    IntQuant committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    23b8567 View commit details
    Browse the repository at this point in the history

  5. Migrate SuggestTuplePattern

    @IntQuant
    IntQuant committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    d18adb7 View commit details
    Browse the repository at this point in the history

  6. Migrate TupleTrailingCommaSuggestion

    @IntQuant
    IntQuant committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    b610ce7 View commit details
    Browse the repository at this point in the history

  7. FailureCode::Error0038 is unreachable, so can be removed

    @IntQuant
    IntQuant committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    ab11b43 View commit details
    Browse the repository at this point in the history

  8. Migrate (most of) report_and_explain_type_error

    @IntQuant
    IntQuant committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    1f09bc7 View commit details
    Browse the repository at this point in the history

  9. Update compiler/rustc_infer/src/infer/error_reporting/suggest.rs 

    Co-authored-by: David Wood <agile.lion3441@fuligin.ink>
    @IntQuant @davidtwco
    IntQuant and davidtwco committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    e813b6d View commit details
    Browse the repository at this point in the history

  10. Move and document escape_literal function

    @IntQuant
    IntQuant committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    aa33a6f View commit details
    Browse the repository at this point in the history

  11. Renamed TypeErrorAdditionalDiags (was Error0308Subdiags) and Obligati… 

    …onCauseFailureCode (was FailureCodeDiagnostics)
    @IntQuant
    IntQuant committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    fd18d9a View commit details
    Browse the repository at this point in the history

  12. A more general implementation of IntoDiagnosticArg for Binder (Al… 

    …so removes `DiagArg`, as it's no longer necessary)
    @IntQuant
    IntQuant committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    6a05cd8 View commit details
    Browse the repository at this point in the history

  13. Extract suggest_specify_actual_length into a separate function

    @IntQuant
    IntQuant committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    21d5bed View commit details
    Browse the repository at this point in the history

  14. Rename tuple_wrap_err_subdiag to suggest_wrap_to_build_a_tuple, makin… 

    …g it more consistent with similar functions
    @IntQuant
    IntQuant committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    467d367 View commit details
    Browse the repository at this point in the history

  15. Now passes tests

    @IntQuant
    IntQuant committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    3fb6d6b View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2023

  1. Call into_diagnostic_arg on Binder's contained value directly.

    @IntQuant
    IntQuant committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    d07b1cd View commit details
    Browse the repository at this point in the history