Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infer: fix and improve comments #108728

Merged
merged 1 commit into from
Mar 7, 2023
Merged

infer: fix and improve comments #108728

merged 1 commit into from
Mar 7, 2023

Conversation

tshepang
Copy link
Member

@tshepang tshepang commented Mar 4, 2023

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Mar 4, 2023

r? @michaelwoerister

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 4, 2023
@michaelwoerister
Copy link
Member

Thanks, @tshepang! Looks good to me.

@bors r+

@bors
Copy link
Contributor

bors commented Mar 6, 2023

📌 Commit 34063c5 has been approved by michaelwoerister

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 7, 2023
@matthiaskrgr
Rollup merge of rust-lang#108728 - tshepang:fix-and-improve, r=michae…
732df3f 
…lwoerister

infer: fix and improve comments
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 7, 2023
Closed
@JohnTitor JohnTitor mentioned this pull request Mar 7, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 7, 2023
@bors
Auto merge of rust-lang#108863 - JohnTitor:rollup-haydnsw, r=JohnTitor
1a521db 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#108619 (Remove the option to disable `llvm-version-check`)
 - rust-lang#108728 (infer: fix and improve comments)
 - rust-lang#108731 (feat: impl better help for `.poll()` not found on `impl Future`)
 - rust-lang#108774 (Greatly improve the error messages when `run-make/translation` fails)
 - rust-lang#108805 (Update askama to 0.12 and improve whitespace control)
 - rust-lang#108823 (Add tracking issue for cf-protection to unstable book)
 - rust-lang#108855 (Custom MIR: Support `as` casts)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2a196db into rust-lang:master Mar 7, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 7, 2023
@tshepang tshepang deleted the fix-and-improve branch March 7, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tshepang @rustbot @michaelwoerister @bors