fix ignore header in MSVC test

[lqd]

From @pietroalbini's zulip message

there are tests like tests/ui/panic-runtime/unwind-tables-target-required.rs which have only-x86_64-windows-msvc which I'm pretty sure is invalid

This test is currently ignored on x64 MSVC CI because of this incorrect target. We'll see if it still passes.

r? @pietroalbini

[wesleywiser]

r=me unless you really want Pietro to approve 🙂

[lqd]

Not necessarily, so thanks Wesley 🙏

We're not 100% sure the test will pass CI, so let's not roll it up unconditionally. It seems probable that it could succeed.

@bors r=wesleywiser rollup=iffy

[bors]

📌 Commit 3c8078a70f4cf4cf5bfa5239b363d1b4e59d8d20 has been approved by wesleywiser

It is now in the queue for this repository.

[pietroalbini]

Heh my plan was to fix this when starting to validate ignore and only, thank you for proactively fixing it!

[bors]

⌛ Testing commit 3c8078a70f4cf4cf5bfa5239b363d1b4e59d8d20 with merge 33ba73e8ae57e467415899ce019d93d52760d517...

[bors]

💔 Test failed - checks-actions

[lqd]

test [ui] tests\ui\panic-runtime\unwind-tables-target-required.rs ... FAILED

The fact that this test fails (or has regressed) isn't a big problem thankfully: it's only testing CLI behavior. So I've fixed the test pattern and took care of the expectations (we don't really need to bless them here).

I'm quite confident it will pass on CI now, even rolled up.

[pietroalbini]

@bors r+

[bors]

📌 Commit 956bebb has been approved by pietroalbini

It is now in the queue for this repository.

[bors]

⌛ Testing commit 956bebb with merge f63872b77943ce45144a81665bb9107134939eb3...

[bors]

💔 Test failed - checks-actions

[rust-log-analyzer]

The job x86_64-gnu-aux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

error: process exited with code 101 (expected 0)
--- stdout

--- stderr
error: could not execute process `/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/tmp/cit/t2605/lib/./foo -vV` (never executed)
Caused by:
  Text file busy (os error 26)
', src/tools/cargo/tests/testsuite/workspaces.rs:2175:42

---
test result: FAILED. 2636 passed; 1 failed; 166 ignored; 0 measured; 0 filtered out; finished in 91.71s

error: test failed, to rerun pass `--test testsuite`
Build completed unsuccessfully in 0:20:57
make: *** [Makefile:44: check-aux] Error 1

[lqd]

That looks unrelated, and probably spurious.

@bors retry

[bors]

⌛ Testing commit 956bebb with merge bfcdf522a6d7d7cbf8cc26c8668ae56a13f95008...

[dtolnay]

@bors retry

Yielding to #109183, which needs to be in the next nightly.

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[bors]

⌛ Testing commit 956bebb with merge cd6c574...

[bors]

☀️ Test successful - checks-actions
Approved by: pietroalbini
Pushing cd6c574 to master...

[rust-timer]

Finished benchmarking commit (cd6c574): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.3%, -0.3%]	1
Improvements ✅ (secondary)	-1.0%	[-1.3%, -0.9%]	6
All ❌✅ (primary)	-0.3%	[-0.3%, -0.3%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.1%	[1.1%, 1.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.1%	[-1.1%, -1.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.0%	[-1.1%, 1.1%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.4%, -0.4%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.4%	[-0.4%, -0.4%]	1

[lqd]

note for perf triage: tt-muncher is currently noisy.