rustdoc: use restricted Damerau-Levenshtein distance for search #109009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jsha (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
notriddle
force-pushed
the
notriddle/edit-distance
branch
2 times, most recently
from
90381ba
to
a60de8f
Compare
Based on rust-lang#108200, for the same rationale. > This replaces the existing Levenshtein algorithm with the > Damerau-Levenshtein algorithm. This means that "ab" to "ba" is one change > (a transposition) instead of two (a deletion and insertion). More > specifically, this is a restricted implementation, in that "ca" to "abc" > cannot be performed as "ca" → "ac" → "abc", as there is an insertion in the > middle of a transposition. I believe that errors like that are sufficiently > rare that it's not worth taking into account. Before this change, searching `prinltn!` listed `print!` first, followed by `println!`. With this change, `println!` matches more closely.
notriddle
force-pushed
the
notriddle/edit-distance
branch
from
a60de8f
to
dfd9e5e
Compare
notriddle
force-pushed
the
notriddle/edit-distance
branch
from
c044c6e
to
80e61e2
Compare
notriddle
force-pushed
the
notriddle/edit-distance
branch
from
80e61e2
to
ce795d9
Compare
GuillaumeGomez
approved these changes
Mar 12, 2023
|
It's a great improvement and putting it into one place really improves the reading. Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 12, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#108651 (Forbid the use of `#[target_feature]` on `main`) - rust-lang#109009 (rustdoc: use restricted Damerau-Levenshtein distance for search) - rust-lang#109026 (Introduce `Rc::into_inner`, as a parallel to `Arc::into_inner`) - rust-lang#109029 (Gate usages of `dyn*` and const closures in macros) - rust-lang#109031 (Rename `config.toml.example` to `config.example.toml`) - rust-lang#109032 (Use `TyCtxt::trait_solver_next` in some places) - rust-lang#109047 (typo) - rust-lang#109052 (Add eslint check for rustdoc-gui tester) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #108200, for the same rationale.
Before this change, searching
prinltn!listedprint!first, followed byprintln!. With this change,println!matches more closely.