-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 10 pull requests #109430
Rollup of 10 pull requests #109430
Commits on Jan 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 01d6c04 - Browse repository at this point
Copy the full SHA 01d6c04View commit details
Commits on Mar 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ed63201 - Browse repository at this point
Copy the full SHA ed63201View commit details
Commits on Mar 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ee31e5f - Browse repository at this point
Copy the full SHA ee31e5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ea08d3a - Browse repository at this point
Copy the full SHA ea08d3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ce14a1e - Browse repository at this point
Copy the full SHA ce14a1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e06c62c - Browse repository at this point
Copy the full SHA e06c62cView commit details -
Configuration menu - View commit details
-
Copy full SHA for aa8de17 - Browse repository at this point
Copy the full SHA aa8de17View commit details -
Configuration menu - View commit details
-
Copy full SHA for e624ef4 - Browse repository at this point
Copy the full SHA e624ef4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9df35a5 - Browse repository at this point
Copy the full SHA 9df35a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b85bc19 - Browse repository at this point
Copy the full SHA b85bc19View commit details
Commits on Mar 19, 2023
-
rustdoc: Cleanup parent module tracking for doc links
Keep ids of the documented items themselves, not their parent modules. Parent modules can be retreived from those ids when necessary.
Configuration menu - View commit details
-
Copy full SHA for f7a9702 - Browse repository at this point
Copy the full SHA f7a9702View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae47810 - Browse repository at this point
Copy the full SHA ae47810View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69a82f7 - Browse repository at this point
Copy the full SHA 69a82f7View commit details
Commits on Mar 20, 2023
-
Walk un-shifted nested
impl Trait
in trait when setting up default ……trait method assumptions
Configuration menu - View commit details
-
Copy full SHA for 9f80c75 - Browse repository at this point
Copy the full SHA 9f80c75View commit details -
Configuration menu - View commit details
-
Copy full SHA for 239ec6c - Browse repository at this point
Copy the full SHA 239ec6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b4fa5b - Browse repository at this point
Copy the full SHA 5b4fa5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e4e55e - Browse repository at this point
Copy the full SHA 8e4e55eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e24f5ac - Browse repository at this point
Copy the full SHA e24f5acView commit details -
Use builtin_index instead of match
Co-authored-by: Oli Scherer <github35764891676564198441@oli-obk.de>
Configuration menu - View commit details
-
Copy full SHA for f404f33 - Browse repository at this point
Copy the full SHA f404f33View commit details -
Configuration menu - View commit details
-
Copy full SHA for f321144 - Browse repository at this point
Copy the full SHA f321144View commit details -
Configuration menu - View commit details
-
Copy full SHA for cbb8066 - Browse repository at this point
Copy the full SHA cbb8066View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5058cc8 - Browse repository at this point
Copy the full SHA 5058cc8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 720cc40 - Browse repository at this point
Copy the full SHA 720cc40View commit details
Commits on Mar 21, 2023
-
Rollup merge of rust-lang#106434 - clubby789:document-sum-result, r=t…
…he8472 Document `Iterator::sum/product` for Option/Result Closes rust-lang#105266 We already document the similar behavior for `collect()` so I believe it makes sense to add this too. The Option/Result implementations *are* documented on their respective pages and the page for `Sum`, but buried amongst many other trait impls which doesn't make it very discoverable. ``@rustbot`` label +A-docs
Configuration menu - View commit details
-
Copy full SHA for 948cb7f - Browse repository at this point
Copy the full SHA 948cb7fView commit details -
Rollup merge of rust-lang#108842 - compiler-errors:non_lifetime_binde…
…rs-object-safe, r=b-naber Enforce non-lifetime-binders in supertrait preds are not object safe We can't construct vtables for these supertraits.
Configuration menu - View commit details
-
Copy full SHA for 3847c6e - Browse repository at this point
Copy the full SHA 3847c6eView commit details -
Rollup merge of rust-lang#108896 - BoxyUwU:new_solver_add_goal_fn, r=…
…lcnr new solver: make all goal evaluation able to be automatically rerun It is generally wrong to call `evaluate_goal` multiple times or `evaluate_goal` and `evaluate_all` for the same `QueryResult` without correctly handling rerunning the goals when inference makes progress. Not doing so will result in the assertion in `evaluate_goal` firing because rerunning the goal will lead to a more accurate `QueryResult`. Currently there are lots of places that get this wrong and generally it is complex and error prone to handle correctly everywhere. This PR introduces a way to add goals to the `EvalCtxt` and then run all the added goals in a loop so that `evaluate_goal`/`evaluate_all` is not necessary to call manually. There are a few complications for making everything work "right": 1. the `normalizes-to` hack that replaces the rhs with an unconstrained infer var requires special casing in the new `try_evaluate_added_goals` function similar to how `evaluate_goal`'s assertion special cases that hack. 2. `assemble_candidates_after_normalizing_self_ty`'s normalization step needs to be reran for each candidate otherwise the found candidates will potentially get a more accurate `QueryResult` when rerunning the projection/trait goal which can effect the `QueryResult` of the projection/trait goal. This is implemented via `EvalCtxt::probe`'s closure's `EvalCtxt` inheriting the added goals of the `EvalCtxt` that `probe` is called on, allowing us to add goals in a probe, and then enter a nested probe for each candidate and evaluate added goals which include the normalization step's goals. I made `make_canonical_response` evaluate added goals so that it will be hard to mess up the impl of the solver by forgetting to evaluate added goals. Right now the only way to mess this up would be to call `response_no_constraints` (which from the name is obviously weird). The visibility of `evaluate_goal` means that it can be called from various `compute_x_goal` or candidate assembly functions, this is generally wrong and we should never call `evaluate_goal` manually, instead we should be calling `add_goal`/`add_goals`. This is solved by moving `evaluate_goal` `evaluate_canonical_goal` and `compute_goal` into `eval_ctxt`'s module and making them private so they cannot be called from elsewhere, forcing people to call `add_goal/s` and `evaluate_added_goals_and_make_canonical_resposne`/`try_evaluate_added_goals` --- Other changes: - removed the `&& false` that was introduced to the assertion in `evaluate_goal` in rust-lang#108839 - remove a `!self.did_overflow()` requirement in `search_graph.is_empty()` which causes goals that overflow to ICE - made `EvalCtxt::eq` take `&mut self` and add all the nested goals via `add_goals` instead of returning them as 99% of call sites just immediately called `EvalCtxt::add_goals` manually. r? ``@lcnr``
Configuration menu - View commit details
-
Copy full SHA for fd24644 - Browse repository at this point
Copy the full SHA fd24644View commit details -
Rollup merge of rust-lang#109240 - compiler-errors:dont-binder-twice,…
… r=oli-obk Walk un-shifted nested `impl Trait` in trait when setting up default trait method assumptions Fixes a double subtraction in some binder math in return-position `impl Trait` in trait handling code. Fixes rust-lang#109239
Configuration menu - View commit details
-
Copy full SHA for 1c8b70f - Browse repository at this point
Copy the full SHA 1c8b70fView commit details -
Rollup merge of rust-lang#109312 - petrochenkov:docice5, r=GuillaumeG…
…omez rustdoc: Cleanup parent module tracking for doc links Keep ids of the documented items themselves, not their parent modules. Parent modules can be retreived from those ids when necessary. Fixes rust-lang#108501. That issue could be fixed in a more local way, but this refactoring is something that I wanted to do since rust-lang#93805 anyway.
Configuration menu - View commit details
-
Copy full SHA for 86c02fb - Browse repository at this point
Copy the full SHA 86c02fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2fc15dd - Browse repository at this point
Copy the full SHA 2fc15ddView commit details -
Rollup merge of rust-lang#109386 - aDotInTheVoid:mailmap, r=WaffleLapkin
add myself to mailmap CC rust-lang/team#951
Configuration menu - View commit details
-
Copy full SHA for a131701 - Browse repository at this point
Copy the full SHA a131701View commit details -
Rollup merge of rust-lang#109390 - cbeuw:aggregate-lit, r=oli-obk
Custom MIR: Support aggregate expressions Add support for tuple, array and ADT expressions in custom mir r? `@oli-obk` or `@tmiasko` or `@JakobDegen`
Configuration menu - View commit details
-
Copy full SHA for 06a0aff - Browse repository at this point
Copy the full SHA 06a0affView commit details -
Rollup merge of rust-lang#109403 - chenyukang:yukang/fix-109396, r=es…
…tebank Avoid ICE of attempt to add with overflow in emitter Fixes rust-lang#109396 r? `@estebank`
Configuration menu - View commit details
-
Copy full SHA for c3f18ef - Browse repository at this point
Copy the full SHA c3f18efView commit details -
Rollup merge of rust-lang#109408 - RalfJung:retags, r=compiler-errors
not *all* retags might be explicit in Runtime MIR In rust-lang#105317 I made Miri treat `Rvalue::Ref/AddrOf` as implicit retagging sites. This updates the MIR docs accordingly. For `Rvalue::Ref` I think this makes a lot more sense: creating a new reference is their entire point, so we can avoid bloating the MIR with retags. Also this seems to be the best way to handle cases like `*ptr = &[mut] ...`, where doing a retag is somewhat questionable since maybe `*ptr` points to another place now? For `Rvalue::AddrOf`, Stacked Borrows needs this because even raw ptrs need some retagging, but Tree Borrows doesn't do ant retagging here and I hope we'll end up with a model where raw pointers don't get retagged.
Configuration menu - View commit details
-
Copy full SHA for 6f99503 - Browse repository at this point
Copy the full SHA 6f99503View commit details