Refactor: Separate LocalRef variant for not-evaluated-yet operands
#109582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @oli-obk (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
scottmcm
commented
Mar 25, 2023
| @@ -558,6 +558,9 @@ impl<'a, 'tcx, Bx: BuilderMethods<'a, 'tcx>> FunctionCx<'a, 'tcx, Bx> { | |||
| bug!("using operand local {:?} as place", place_ref); | |||
| } | |||
| } | |||
| LocalRef::PendingOperand => { | |||
| bug!("using still-pending operand local {:?} as place", place_ref); | |||
There was a problem hiding this comment.
This is the one place that wasn't already distinguishing between Some/None, and near as I can tell that's just because the None case is impossible -- at least it seems plausible that we should never be using a not-evaluated-yet operand as a place, and I never hit an ICE from a stage2 build nor any codegen tests having added this check.
|
@bors r+ rollup nice! |
bors
added
S-waiting-on-bors
|
@bors r+ rollup nice! |
|
💡 This pull request was already approved, no need to approve it again.
|
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 27, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#108625 (More config.toml.example cleanups) - rust-lang#109418 (Rename 'src/bootstrap/native.rs' to llvm.rs) - rust-lang#109580 (Remove some stale FIXMEs in new solver) - rust-lang#109582 (Refactor: Separate `LocalRef` variant for not-evaluated-yet operands) - rust-lang#109650 (Remove Nilstrieb from review rotation) - rust-lang#109656 (Update cargo) - rust-lang#109658 (Backport 1.68.1 and 1.68.2 release notes to `master`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was reading through this, I noticed that almost every place that was using this needed to distinguish between Some vs None in the match arm anyway, so thought that separating the cases at the variant level might be clearer instead.
I like how it ended up; let me know what you think!