Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement read_buf for RustHermit #109722

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Implement read_buf for RustHermit #109722

merged 1 commit into from
Apr 3, 2023

Conversation

stlankes
Copy link
Contributor

In principle, this PR extends #108326 for RustyHermit.

@stlankes
Implement read_buf for RustHermit
a9aaf3f 
In principle, this PR extends rust-lang#108326 for RustyHermit.

Signed-off-by: Stefan Lankes <slankes@eonerc.rwth-aachen.de>
@rustbot
Copy link
Collaborator

rustbot commented Mar 29, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 29, 2023
@rustbot
Copy link
Collaborator

rustbot commented Mar 29, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 2, 2023

📌 Commit a9aaf3f has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 2, 2023
@matthiaskrgr
Rollup merge of rust-lang#109722 - hermitcore:read, r=Mark-Simulacrum
e79ef4d 
Implement read_buf for RustHermit

In principle, this PR extends rust-lang#108326 for RustyHermit.
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 2, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 3, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 3, 2023
@bors
Auto merge of rust-lang#109884 - matthiaskrgr:rollup-5wapig9, r=matth…
932c173 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#109526 (LIBPATH is used as dylib's path environment variable on AIX)
 - rust-lang#109642 (check for missing codegen backeng config)
 - rust-lang#109722 (Implement read_buf for RustHermit)
 - rust-lang#109856 (fix(middle): emit error rather than delay bug when reaching limit)
 - rust-lang#109868 (Improve PR job names in Github Actions preview)
 - rust-lang#109871 (Include invocation start times)
 - rust-lang#109873 (Move some UI tests into subdirectories)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f2f5efc into rust-lang:master Apr 3, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 3, 2023
@stlankes stlankes deleted the read branch April 3, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.
4 participants
@stlankes @rustbot @Mark-Simulacrum @bors