Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove box_syntax usage #110058

Merged
merged 1 commit into from
Apr 9, 2023
Merged

Remove box_syntax usage #110058

merged 1 commit into from
Apr 9, 2023

Conversation

gimbling-away
Copy link
Contributor

Fixes #109978

@rustbot
Copy link
Collaborator

rustbot commented Apr 7, 2023

r? @GuillaumeGomez

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 7, 2023
@gimbling-away gimbling-away marked this pull request as draft April 7, 2023 18:03
@Noratrieb
Copy link
Member

There are other uses of it here, for example in plugins.md as mentioned.

@GuillaumeGomez
Copy link
Member

r? rust-lang/libs

@rustbot rustbot assigned cuviper and unassigned GuillaumeGomez Apr 7, 2023
@Noratrieb
Copy link
Member

r? Nilstrieb
This isn't really libs, I'll take it over

@rustbot rustbot assigned Noratrieb and unassigned cuviper Apr 7, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@gimbling-away
rm box_items
f1ded91 
fix in plugin.md

fmt
@KittyBorgX KittyBorgX mentioned this pull request Apr 8, 2023
Merged
@gimbling-away gimbling-away marked this pull request as ready for review April 8, 2023 10:24
@Noratrieb
Copy link
Member

Did you check whether there are more usages of it?

@gimbling-away
Copy link
Contributor Author

I did, yes, all other usages seem to be unrelated.

@Noratrieb
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 8, 2023

📌 Commit f1ded91 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 8, 2023
@JohnTitor JohnTitor mentioned this pull request Apr 9, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 9, 2023
@bors
Auto merge of rust-lang#110101 - JohnTitor:rollup-ol20aw7, r=JohnTitor
7cd6f55 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#110058 (Remove `box_syntax` usage)
 - rust-lang#110059 (ignore_git → omit_git_hash)
 - rust-lang#110060 (Document that `&T` and `&mut T` are `Sync` if `T` is)
 - rust-lang#110074 (Make the "codegen" profile of `config.toml` download and build llvm from source.)
 - rust-lang#110086 (Add `max_line_length` to `.editorconfig`, matching rustfmt)
 - rust-lang#110096 (Tweak tuple indexing suggestion)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f001f7b into rust-lang:master Apr 9, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noratrieb Noratrieb Noratrieb approved these changes

Assignees

@Noratrieb Noratrieb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.

Unstable book uses box_syntax
7 participants
@gimbling-away @rustbot @Noratrieb @GuillaumeGomez @rust-log-analyzer @bors @cuviper