Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: migrate item_keyword to an askama template #111314

Closed

Conversation

nicklimmm
Copy link
Contributor

Part of #108868

@rustbot
Copy link
Collaborator

rustbot commented May 7, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels May 7, 2023
@GuillaumeGomez
Copy link
Member

I'm not sure it's worth it here. It adds a lot of code and the template only calls the document function...

@nicklimmm
Copy link
Contributor Author

I'm not sure it's worth it here. It adds a lot of code and the template only calls the document function...

I do feel the same while implementing this. Do feel free to close this PR then.

@GuillaumeGomez
Copy link
Member

Don't hesitate to take a look at the other items on the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants