Start node has no immediate dominator #111547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Would it be more consistent to make the |
|
Right now there is no other information that would describe which nodes are reachable, nor which node is the start node (the code is generic and works with arbitrary control flow graphs, not just MIR basic blocks). Of course, I can add information about the start node, if you prefer that approach. |
|
Yes, that would be more natural. The algorithm in this file is complicated enough to avoid adding corner cases. |
tmiasko
force-pushed
the
immediate-dominator
branch
from
7252d31
to
716e706
Compare
Change the immediate_dominator return type to Option, and use None to indicate that node has no immediate dominator. Also fix the issue where the start node would be returned as its own immediate dominator.
tmiasko
force-pushed
the
immediate-dominator
branch
from
716e706
to
f16d2b1
Compare
|
Thanks! |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 15, 2023
…illot Start node has no immediate dominator Change the immediate_dominator return type to Option, and use None to indicate that node has no immediate dominator. Also fix the issue where the start node would be returned as its own immediate dominator.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#102673 (Update doc for `PhantomData` to match code example) - rust-lang#111531 (Fix ice caused by shorthand fields in NoFieldsForFnCall) - rust-lang#111547 (Start node has no immediate dominator) - rust-lang#111548 (add util function to TokenStream to eliminate some clones) - rust-lang#111560 (Simplify find_width_of_character_at_span.) - rust-lang#111569 (Appease lints) - rust-lang#111581 (Fix some misleading and copy-pasted `Pattern` examples) - rust-lang#111582 ((docs) Change "wanting" to "want") Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the immediate_dominator return type to Option, and use None to
indicate that node has no immediate dominator.
Also fix the issue where the start node would be returned as its own
immediate dominator.