Document rustc_driver by default #112467
Merged
Document rustc_driver by default #112467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Thanks for the PR! |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 10, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#110141 (expand: Change how `#![cfg(FALSE)]` behaves on crate root) - rust-lang#112369 (More CGU cleanups) - rust-lang#112467 (Compile rustc_driver by default) - rust-lang#112468 (Change format of rustdoc-js tests by putting query and correction directly alongside the expected values) - rust-lang#112473 (Update cargo) - rust-lang#112481 (Ignore tests that hang in new solver) r? `@ghost` `@rustbot` modify labels: rollup
jyn514
changed the title
jyn514
reviewed
Jun 10, 2023
|
|
||
| if self.crates.is_empty() { | ||
| self.crates = INTERNER.intern_list(vec!["rustc_driver".to_owned()]); | ||
| }; |
There was a problem hiding this comment.
Hmm, I'm not quite sure this is correct. It will document only rustc_driver, not any of its dependencies. I think this should be crates = builder.crate_dependencies(rustc_driver) or something like that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112440. It now properly compiles
rustc_driverand opens the doc page.