Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unnecessary &String -> &str, now that &String implements StableOrd as well #112538

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Removed unnecessary &String -> &str, now that &String implements StableOrd as well #112538

merged 1 commit into from
Jun 21, 2023

Conversation

ndrewxie
Copy link
Contributor

Applied a few nits suggested by lcnr to PR #110040 (nits can be found here.)

Making a new PR because the old one was already merged, and given that this just applies changes that were already suggested, reviewing it should be fairly open-and-shut.

@rustbot
Copy link
Collaborator

rustbot commented Jun 12, 2023

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 12, 2023
@compiler-errors
Copy link
Member

(can you give this PR a better title than just referencing another PR? 😸)

@ndrewxie ndrewxie changed the title Applied nits to #110040 Applied nits to #110040 (removed unnecessary &String -> &str maps in UnordItems, now that &String implements StableOrd as well) Jun 13, 2023
@ndrewxie ndrewxie changed the title Applied nits to #110040 (removed unnecessary &String -> &str maps in UnordItems, now that &String implements StableOrd as well) Removed unnecessary &String -> &str maps in UnordItems from #110040, now that &String implements StableOrd as well) Jun 13, 2023
@ndrewxie ndrewxie changed the title Removed unnecessary &String -> &str maps in UnordItems from #110040, now that &String implements StableOrd as well) Removed unnecessary &String -> &str maps in UnordItems from #110040, now that &String implements StableOrd as well Jun 13, 2023
@compiler-errors compiler-errors changed the title Removed unnecessary &String -> &str maps in UnordItems from #110040, now that &String implements StableOrd as well Removed unnecessary &String -> &str, now that &String implements StableOrd as well Jun 13, 2023
@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jun 21, 2023

📌 Commit 0cac845 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2023
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 21, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 21, 2023
@bors
Auto merge of rust-lang#112900 - GuillaumeGomez:rollup-1blf4io, r=Gui…
065a1f5 
…llaumeGomez

Rollup of 4 pull requests

Successful merges:

 - rust-lang#112538 (Removed unnecessary &String -> &str, now that &String implements StableOrd as well)
 - rust-lang#112868 (Liberate bound vars properly when suggesting missing async-fn-in-trait)
 - rust-lang#112892 (resolve: Minor cleanup to `fn resolve_path_with_ribs`)
 - rust-lang#112894 (Fix union fields display)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a5561eb into rust-lang:master Jun 21, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davidtwco davidtwco

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ndrewxie @rustbot @compiler-errors @bors @davidtwco