Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Placeholder, GeneratorWitness*, Infer and Error unreachable on SMIR rustc_ty_to_ty #113553

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

spastorino
Copy link
Member

Let's remove these todos to not confuse @ericmarkmartin if they pick some conversion up.

r? @oli-obk

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 10, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jul 10, 2023

This PR changes Stable MIR

cc @oli-obk, @celinval

@spastorino spastorino changed the title Make Placeholder, GeneratorWitnessMIR, Infer and Error unreachable on SMIR rustc_ty_to_ty Make Placeholder, GeneratorWitness*, Infer and Error unreachable on SMIR rustc_ty_to_ty Jul 11, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Jul 12, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 12, 2023

📌 Commit 715cd99 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 12, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 12, 2023
Make Placeholder, GeneratorWitness*, Infer and Error unreachable on SMIR rustc_ty_to_ty

Let's remove these todos to not confuse `@ericmarkmartin` if they pick some conversion up.

r? `@oli-obk`
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 13, 2023
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#113353 (Implement selection for `Unsize` for better coercion behavior)
 - rust-lang#113553 (Make Placeholder, GeneratorWitness*, Infer and Error unreachable on SMIR rustc_ty_to_ty)
 - rust-lang#113598 (Update cargo)
 - rust-lang#113603 (Test simd-wide-sum for codegen error)
 - rust-lang#113613 (Allow to have `-` in rustdoc-json test file name)
 - rust-lang#113615 (llvm-wrapper: adapt for LLVM API change)
 - rust-lang#113616 (Fix bootstrap.py uname error)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 66233fb into rust-lang:master Jul 13, 2023
11 checks passed
@rustbot rustbot added this to the 1.73.0 milestone Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants