Add symbols for Clippy usage #115177
Merged
Add symbols for Clippy usage #115177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jackh726 (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
@c410-f3r: do you also want to modify |
|
Thanks for the response @compiler-errors Hum... The current Clippy code of |
|
I guess this is fine, but pls make sure to actually use them after the next clippy sync :) @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 25, 2023
Rollup of 9 pull requests Successful merges: - rust-lang#114987 (elaborate a bit on the (lack of) safety in 'Mmap::map') - rust-lang#115084 (Add smir `predicates_of`) - rust-lang#115117 (Detect and report nix shell) - rust-lang#115124 (kmc-solid: Import `std::sync::PoisonError` in `std::sys::solid::os`) - rust-lang#115152 (refactor(lint): translate `RenamedOrRemovedLint`) - rust-lang#115154 (Move some ui tests to subdirectories) - rust-lang#115167 (Fix ub-int-array test for big-endian platforms) - rust-lang#115172 (Add more tests for if_let_guard) - rust-lang#115177 (Add symbols for Clippy usage) r? `@ghost` `@rustbot` modify labels: rollup
This was referenced Aug 25, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 1, 2023
[`Clippy`] Use symbols intended for `arithmetic_side_effects` rust-lang#115177 added the symbols for `arithmetic_side_effects` and now this PR actually uses them to prevent an eventual removal. All because rust-lang#115183 was recently merged and next Clippy update will probably take some time to happen. Fixes rust-lang/rust-clippy#11392
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
arithmetic_side_effectslint is always "interning" these non-existing symbols related to math operations causing a bit of a slowdown.