fix(sys/hermit): remove obsolete network initialization

[mkroening]

This function does not exist as of hermit-sys 0.4.1 (e38f246). Once std does not call this function, we can remove it entirely.

CC: @stlankes

[rustbot]

r? @cuviper

(rustbot has picked a reviewer for you, use r? to override)

[cuviper]

I haven't looked at hermit before -- how does hermit-sys enter the build? It would seem prudent to make sure the dependency is new enough, but I don't even see it in Cargo.lock.

[mkroening]

Sorry for the confusion.

Hermit is a library operating system. That means users explicitly link their application against the whole OS to create a unikernel image, that can be run in VMs.

Here, hermit-abi contains the kernel's symbol names. The OS implementation of these symbols is built and linked to by hermit-sys (today renamed to just hermit). Only hermit-abi is checked into Rust's Cargo.lock for two reasons: not pollute the Cargo.lock with a full operating system, and let users update the OS independently.

So users have to update hermit-sys manually when updating their Rust toolchain and vice versa. This allows us to avoid committing to certain OS APIs.

[cuviper]

OK, thanks for explaining!

@bors r+ rollup

[bors]

📌 Commit 5853c2b has been approved by cuviper

It is now in the queue for this repository.

[bors]

⌛ Testing commit 5853c2b with merge fef2f59...

[bors]

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing fef2f59 to master...

[rust-timer]

Finished benchmarking commit (fef2f59): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.1%	[-4.1%, -2.2%]	2
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 629.903s -> 630.211s (0.05%)
Artifact size: 316.24 MiB -> 316.20 MiB (-0.01%)