issue has since been fixed #115558
Merged
issue has since been fixed #115558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
The issue is closed, but I don't think this is actually fixed. We don't (AFAIK) test the non-cgu=1 configuration on CI. |
|
should a new issue be opened, so that this points to something open |
|
I think we should just drop the issue link, this is always going to be a little buggy unless we test it in CI. I don't expect CI testing here to be worth the cost. r=me with that done. |
|
@bors r=Mark-Simulacrum rollup |
|
@tshepang: 🔑 Insufficient privileges: Not in reviewers |
|
@tshepang: 🔑 Insufficient privileges: not in try users |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Sep 18, 2023
issue has since been fixed
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 18, 2023
issue has since been fixed
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 18, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#115558 (issue has since been fixed) - rust-lang#115724 (Add myself to the mailmap) - rust-lang#115795 (Refactor `opt-dist` to simplify local building) - rust-lang#115811 (Make AIX known by bootstrap) - rust-lang#115838 (inspect: closer to proof trees for coherence) - rust-lang#115902 (Fix up a few CI images) - rust-lang#115907 (nop_lift macros: ensure that we are using the right interner) - rust-lang#115916 (Add me as on vacation) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 18, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#115558 (issue has since been fixed) - rust-lang#115724 (Add myself to the mailmap) - rust-lang#115811 (Make AIX known by bootstrap) - rust-lang#115838 (inspect: closer to proof trees for coherence) - rust-lang#115902 (Fix up a few CI images) - rust-lang#115907 (nop_lift macros: ensure that we are using the right interner) - rust-lang#115908 (Do not clone MIR for const-prop lint.) - rust-lang#115916 (Add me as on vacation) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 18, 2023
Rollup merge of rust-lang#115558 - tshepang:patch-4, r=Mark-Simulacrum issue has since been fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.