Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 4 pull requests #115848

Merged
merged 8 commits into from
Sep 14, 2023
Merged

Rollup of 4 pull requests #115848

merged 8 commits into from
Sep 14, 2023

Commits on Sep 13, 2023

  1. span is index

    ouz-a committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    fa57a48 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Configuration menu
    Copy the full SHA
    c397ca0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7ae301e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0277184 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#115772 - ouz-a:smir_span2, r=oli-obk

    Improve Span in smir
    
    Addressing rust-lang/project-stable-mir#31
    
    r? ``@oli-obk``
    matthiaskrgr authored Sep 14, 2023
    Configuration menu
    Copy the full SHA
    4f90a52 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#115832 - Zalathar:fix-no-coverage, r=oli-obk

    Fix the error message for `#![feature(no_coverage)]`
    
    When rust-lang#114656 was written, the feature flag to replace `no_coverage` was originally spelled `coverage`, but it was eventually changed to `coverage_attribute` instead.
    
    That update happened to miss this error message in `removed.rs`, and unfortunately I only noticed just *after* the original PR was approved and merged.
    
    cc ``@bossmc`` (original author) ``@oli-obk`` (original reviewer)
    ``@rustbot`` label +A-code-coverage
    matthiaskrgr authored Sep 14, 2023
    Configuration menu
    Copy the full SHA
    3dbcc28 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#115834 - compiler-errors:binder-vars, r=jac…

    …kh726
    
    Properly consider binder vars in `HasTypeFlagsVisitor`
    
    Given a PolyTraitRef like `for<'a> Ty: Trait` (where neither `Ty` nor `Trait` mention `'a`), we do *not* return true for `.has_type_flags(TypeFlags::HAS_LATE_BOUND)`, even though binders are supposed to act as if they have late-bound vars even if they don't mention them in their bound value: 31ae3b2. This is because we use `HasTypeFlagsVisitor`, which only computes the type flags for `Ty`, `Const` and `Region` and `Predicates`, and we consequently skip any binders (and setting flags for their vars) that are not contained in one of these types.
    
    This ends up causing a problem, because when we call `TyCtxt::erase_regions` (which both erases regions *and* anonymizes bound vars), we will skip such a PolyTraitRef, not anonymizing it, and therefore not making it structurally equal to other binders. This breaks vtable computations.
    
    This PR computes the flags for all binders we enter in `HasTypeFlagsVisitor` if we're looking for `TypeFlags::HAS_LATE_BOUND` (or `TypeFlags::HAS_{RE,TY,CT}_LATE_BOUND`).
    
    Fixes rust-lang#115807
    matthiaskrgr authored Sep 14, 2023
    Configuration menu
    Copy the full SHA
    5737082 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#115844 - oli-obk:opaque_lifetime_ambiguity,…

    … r=jackh726
    
    Paper over an accidental regression
    
    r? types
    
    cc rust-lang#115781 (do not close issue until beta backport has been performed)
    
    The PR reasons are explained with comments in the source.
    
    In order to keep the diff simple, this PR effectively reverts rust-lang#113661, but only for RPITs. I will submit a follow up PR that fixes this correctly instead of just disabling the newly added check for RPITs. This PR should be significantly easier to review for beta backport
    matthiaskrgr authored Sep 14, 2023
    Configuration menu
    Copy the full SHA
    9362604 View commit details
    Browse the repository at this point in the history