⬆️ rust-analyzer
#116136
Closed
⬆️ rust-analyzer
#116136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…garding invocation strategy and location
Tested for two cases: 1. Simple Use 2. Complex Use
…arms, r=Veykril Deunwrap add_missing_match_arms Last subtask of rust-lang#15398
…ock, r=Veykril minor : Deunwrap convert_comment_block and desugar_doc_comment Closes subtask 13 of rust-lang#15398 . I still don't know a more idiomatic way for the for loops I added, any suggestion would make me happy.
extend check.overrideCommand and buildScripts.overrideCommand docs Extend check.overrideCommand and buildScripts.overrideCommand docs regarding invocation strategy and location. However something still seems a bit odd -- the docs for `invocationStrategy`/`invocationLocation` talk about "workspaces", but the setting that controls which workspaces are considered is called `linkedProjects`. Is a project the same as a workspace here or is there some subtle difference?
add option to show full function signatures in completion docs implements rust-lang#15538 with `"rust-analyzer.completion.fullFunctionSignatures.enable": false`:  with `"rust-analyzer.completion.fullFunctionSignatures.enable": true`: 
…albasi minor: hover_simple refactor A minor refactor of `hover_simple` opportunity I noticed while skimming through the code. - `if let`s -> `match` - `iter::once(x).cycle` -> `iter::repeat` - `classify_token` -> `classify_node`
rustbot
added
the
S-waiting-on-review
|
Some changes occurred in src/tools/rust-analyzer cc @rust-lang/rust-analyzer |
This comment has been minimized.
This comment has been minimized.
|
CC @HKalbasi
|
|
Hmm, is it renamed? It worked on my machine's nightly. |
|
Maybe |
|
Ah, I missed the It seems we should add |
rustbot
added
the
T-bootstrap
This comment has been minimized.
This comment has been minimized.
lnicola
force-pushed
the
sync-from-ra
branch
from
add6ca3
to
2678cd3
Compare
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Huh |
|
Do you have any idea why should this happen? It is a normal dependency without any cfg and things like that. |
|
Nope, maybe we should ask T-infra. |
|
No answers in https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/.22Can't.20find.20crate.22.20on.20RA.20sync.20PR, not sure what to do about future syncs. I didn't try to reproduce it locally though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @ghost