Increase the reach of panic_immediate_abort #117332

saethlin · 2023-10-28T22:46:20Z

I wanted to use/abuse this recently as part of another project, and I was surprised how many panic-related things were left in my binaries if I built a large crate with the feature enabled along with LTO. These changes get all the panic-related symbols that I could find out of my set of locally installed Rust utilities.

rustbot · 2023-10-28T22:46:28Z

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

workingjubilee · 2023-10-28T23:24:20Z

...this looks like it might affect perf, so it might be wise to preemptively check that this isn't going to regress people in the non-usage case.
@bors try @rust-timer queue

bors · 2023-10-28T23:25:29Z

⌛ Trying commit 9faccd1 with merge 10757c7...

Increase the reach of panic_immediate_abort I wanted to use/abuse this recently as part of another project, and I was surprised how many panic-related things were left in my binaries if I built a large crate with the feature enabled along with LTO. These changes get all the panic-related symbols that I could find out of my set of locally installed Rust utilities.

bors · 2023-10-29T00:47:15Z

☀️ Try build successful - checks-actions
Build commit: 10757c7 (10757c7219e9122bfd5f8a986531808979a9de53)

rust-timer · 2023-10-29T03:12:47Z

Finished benchmarking commit (10757c7): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.6%	[-0.6%, -0.6%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.6%	[-0.6%, -0.6%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.7%	[3.7%, 3.7%]	1
Regressions ❌ (secondary)	3.0%	[3.0%, 3.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.7%	[3.7%, 3.7%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.4%	[2.1%, 2.8%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.2%	[-1.2%, -1.2%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.2%	[-1.2%, -1.2%]	1

Bootstrap: 635.482s -> 633.888s (-0.25%)
Artifact size: 304.41 MiB -> 304.41 MiB (-0.00%)

workingjubilee · 2023-10-29T03:28:36Z

Oh, nice. Green numbers.

workingjubilee · 2023-10-29T06:26:53Z

@bors r+

bors · 2023-10-29T06:26:55Z

📌 Commit 9faccd1 has been approved by workingjubilee

It is now in the queue for this repository.

klensy · 2023-10-29T10:52:57Z

library/alloc/src/vec/mod.rs

@@ -1549,8 +1549,7 @@ impl<T, A: Allocator> Vec<T, A> {
    #[track_caller]
    pub fn remove(&mut self, index: usize) -> T {
        #[cold]
-        #[inline(never)]
-        #[track_caller]


Killed track_caller?

Hrm, right. Good catch. I had noticed it but not thought much of it. Is it required to get the panic to disappear? We could #[cfg_attr(not(feature = "panic_immediate_abort"), track_caller)]

🤦

I deleted it because of inconsistency with all the other panic helpers. I think the better move is to add it to all the ones in that module.

workingjubilee · 2023-10-29T11:37:54Z

@bors r- re: track_caller q

workingjubilee · 2023-10-29T18:39:45Z

@bors r+

bors · 2023-10-29T18:39:47Z

📌 Commit 2e7364a has been approved by workingjubilee

It is now in the queue for this repository.

bors · 2023-10-30T00:03:49Z

⌛ Testing commit 2e7364a with merge bcb5798...

bors · 2023-10-30T01:55:52Z

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing bcb5798 to master...

rust-timer · 2023-10-30T04:15:37Z

Finished benchmarking commit (bcb5798): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.6%	[-0.6%, -0.6%]	1
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	5
All ❌✅ (primary)	-0.6%	[-0.6%, -0.6%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	6.1%	[6.1%, 6.1%]	1
Regressions ❌ (secondary)	2.5%	[2.3%, 2.8%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	6.1%	[6.1%, 6.1%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.8%	[-1.2%, -0.7%]	4
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.8%	[-1.2%, -0.7%]	4

Bootstrap: 636.51s -> 635.477s (-0.16%)
Artifact size: 304.44 MiB -> 304.44 MiB (0.00%)

…rt, r=<try> Tweak some attributes to improve panic_immediate_abort This is similar to rust-lang#117332; I did the same approach as before where I build a really big project with `-Zbuild-std -Zbuild-std-features=panic_immediate_abort` and grep its symbols for things that look panic-related.

…rt, r=tgross35 Tweak some attributes to improve panic_immediate_abort This is similar to rust-lang#117332; I did the same approach as before where I build a really big project with `-Zbuild-std -Zbuild-std-features=panic_immediate_abort` and grep its symbols for things that look panic-related.

…oss35 Tweak some attributes to improve panic_immediate_abort This is similar to rust-lang/rust#117332; I did the same approach as before where I build a really big project with `-Zbuild-std -Zbuild-std-features=panic_immediate_abort` and grep its symbols for things that look panic-related.

rustbot assigned Mark-Simulacrum Oct 28, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 28, 2023

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 28, 2023

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 29, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2023

klensy reviewed Oct 29, 2023

View reviewed changes

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 29, 2023

Increase the reach of panic_immediate_abort

2e7364a

saethlin force-pushed the panic-immediate-abort branch from 9faccd1 to 2e7364a Compare October 29, 2023 13:31

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 29, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 30, 2023

bors merged commit bcb5798 into rust-lang:master Oct 30, 2023
12 checks passed

rustbot added this to the 1.75.0 milestone Oct 30, 2023

saethlin deleted the panic-immediate-abort branch October 30, 2023 01:57

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

saethlin mentioned this pull request Aug 25, 2024

Tweak some attributes to improve panic_immediate_abort #129589

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Increase the reach of panic_immediate_abort #117332

Increase the reach of panic_immediate_abort #117332

saethlin commented Oct 28, 2023

rustbot commented Oct 28, 2023

workingjubilee commented Oct 28, 2023 •

edited

Loading

This comment has been minimized.

bors commented Oct 28, 2023

This comment has been minimized.

bors commented Oct 29, 2023

This comment has been minimized.

rust-timer commented Oct 29, 2023

workingjubilee commented Oct 29, 2023

workingjubilee commented Oct 29, 2023

bors commented Oct 29, 2023

klensy Oct 29, 2023

workingjubilee Oct 29, 2023 •

edited

Loading

saethlin Oct 29, 2023

workingjubilee commented Oct 29, 2023 •

edited

Loading

workingjubilee commented Oct 29, 2023

bors commented Oct 29, 2023

bors commented Oct 30, 2023

bors commented Oct 30, 2023

rust-timer commented Oct 30, 2023

Increase the reach of panic_immediate_abort #117332

Increase the reach of panic_immediate_abort #117332

Conversation

saethlin commented Oct 28, 2023

rustbot commented Oct 28, 2023

workingjubilee commented Oct 28, 2023 • edited Loading

This comment has been minimized.

bors commented Oct 28, 2023

This comment has been minimized.

bors commented Oct 29, 2023

This comment has been minimized.

rust-timer commented Oct 29, 2023

Overall result: ✅ improvements - no action needed

workingjubilee commented Oct 29, 2023

workingjubilee commented Oct 29, 2023

bors commented Oct 29, 2023

Choose a reason for hiding this comment

workingjubilee Oct 29, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

workingjubilee commented Oct 29, 2023 • edited Loading

workingjubilee commented Oct 29, 2023

bors commented Oct 29, 2023

bors commented Oct 30, 2023

bors commented Oct 30, 2023

rust-timer commented Oct 30, 2023

Overall result: ✅ improvements - no action needed

workingjubilee commented Oct 28, 2023 •

edited

Loading

workingjubilee Oct 29, 2023 •

edited

Loading

workingjubilee commented Oct 29, 2023 •

edited

Loading