Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 4 pull requests #119053

Merged
merged 8 commits into from
Dec 17, 2023
Merged

Rollup of 4 pull requests #119053

merged 8 commits into from
Dec 17, 2023

Commits on Dec 14, 2023

  1. Configuration menu
    Copy the full SHA
    770013d View commit details
    Browse the repository at this point in the history
  2. Change expr_trailing_brace to an exhaustive match to force new expres…

    …sion kinds to specify whether they contain a brace
    
    Add inline const and other possible curly brace expressions to expr_trailing_brace
    
    Add tests for `}` before `else` in `let...else` error
    
    Change to explicit cases for expressions with optional values when being checked for trailing braces
    
    Add tests for more complex cases of `}` before `else` in `let..else` statement
    
    Move other possible `}` cases into separate arm and add FIXME for future reference
    GearsDatapacks committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    1fc6dbc View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2023

  1. Configuration menu
    Copy the full SHA
    20927d3 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2023

  1. Configuration menu
    Copy the full SHA
    8022057 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#118880 - GearsDatapacks:issue-118859-fix, r…

    …=compiler-errors
    
    More expressions correctly are marked to end with curly braces
    
    Fixes rust-lang#118859, and replaces the mentioned match statement with an exhaustive list, so that this code doesn't get overlooked in the future
    matthiaskrgr authored Dec 17, 2023
    Configuration menu
    Copy the full SHA
    6269bf1 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#118928 - EliseZeroTwo:EliseZeroTwo/fix-issu…

    …e-118786, r=cjgillot
    
    fix: Overlapping spans in delimited meta-vars
    
    Closes rust-lang#118786
    
    Delimited meta-vars inside of MBE's spans were set to have the same opening and closing position resulting in an ICE when debug assertions were enabled and an error was present in the templated code.
    
    This ensures that the spans do not overlap, whilst still having the spans point at the usage of the meta-var inside the macro definition.
    
    It includes a regression test.
    
    🖤
    matthiaskrgr authored Dec 17, 2023
    Configuration menu
    Copy the full SHA
    93d3a42 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#119022 - compiler-errors:no-constness, r=fe…

    …e1-dead
    
    Remove unnecessary constness from ProjectionCandidate
    
    Constness in an item bound will be represented by an effect param, so no need to record constness here.
    
    r? fee1-dead
    matthiaskrgr authored Dec 17, 2023
    Configuration menu
    Copy the full SHA
    677bb6c View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#119052 - cjgillot:gvn-index-overflow, r=com…

    …piler-errors
    
    Avoid overflow in GVN constant indexing.
    
    Fixes rust-lang#118992
    Fixes rust-lang#119008
    matthiaskrgr authored Dec 17, 2023
    Configuration menu
    Copy the full SHA
    39fe059 View commit details
    Browse the repository at this point in the history