Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimpl meaningful test name lint MCP658 #120628

Merged

Commits on Feb 17, 2024

  1. Configuration menu
    Copy the full SHA
    a416fde View commit details
    Browse the repository at this point in the history
  2. Suggest pattern in meaningful test diagnostic

    As the reason for tidy failing the test name may seem slightly opaque,
    provide a suggestion on how to rename the file.
    
    There are some tests which merely would require reordering of the name
    according to the rule. I could modify the diagnostic further to identify
    those, but doing such would make it prone to bad suggestions. I have opted
    to trust contributors to recognize the diagnostic is robotic, as the
    pattern we are linting on is easier to match if we do not speculate on what
    parts of the name are meaningful: sometimes a word is a reason, but
    sometimes it is a mere "tag", such as with a pair like:
    
        issue-314159265-blue.rs
        issue-314159265-red.rs
    
    Starting them with `red-` and `blue-` means they do not sort together,
    despite being related, and the color names are still not very descriptive.
    Recognizing a good name is an open-ended task, though this pair might be:
    
        colored-circle-gen-blue.rs
        colored-circle-gen-red.rs
    
    Deciding exactly how to solve this is not the business of tidy,
    only recognizing a what.
    workingjubilee committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    ba93b49 View commit details
    Browse the repository at this point in the history
  3. Grandfather new questionably-named tests

    ~130 new entries, depending on how you count, with the rest being sorting churn.
    workingjubilee committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    12641b0 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2024

  1. Configuration menu
    Copy the full SHA
    cb57c42 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ce72a3f View commit details
    Browse the repository at this point in the history