-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 9 pull requests #120766
Rollup of 9 pull requests #120766
Commits on Jan 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3ea464f - Browse repository at this point
Copy the full SHA 3ea464fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 96ff1a4 - Browse repository at this point
Copy the full SHA 96ff1a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for e902878 - Browse repository at this point
Copy the full SHA e902878View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09d4613 - Browse repository at this point
Copy the full SHA 09d4613View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0825ad3 - Browse repository at this point
Copy the full SHA 0825ad3View commit details
Commits on Feb 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 16cbdd0 - Browse repository at this point
Copy the full SHA 16cbdd0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e65abc0 - Browse repository at this point
Copy the full SHA e65abc0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a3214b - Browse repository at this point
Copy the full SHA 1a3214bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b6aea72 - Browse repository at this point
Copy the full SHA b6aea72View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7251120 - Browse repository at this point
Copy the full SHA 7251120View commit details -
Configuration menu - View commit details
-
Copy full SHA for 898bb7f - Browse repository at this point
Copy the full SHA 898bb7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c151ed4 - Browse repository at this point
Copy the full SHA c151ed4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6fbd761 - Browse repository at this point
Copy the full SHA 6fbd761View commit details
Commits on Feb 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a2ab48c - Browse repository at this point
Copy the full SHA a2ab48cView commit details
Commits on Feb 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 363b098 - Browse repository at this point
Copy the full SHA 363b098View commit details -
Configuration menu - View commit details
-
Copy full SHA for a61019b - Browse repository at this point
Copy the full SHA a61019bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e8c8d8 - Browse repository at this point
Copy the full SHA 3e8c8d8View commit details -
add test for pretty printing trait objects
Lukas Markeffsky committedFeb 7, 2024 Configuration menu - View commit details
-
Copy full SHA for fd92021 - Browse repository at this point
Copy the full SHA fd92021View commit details -
improve pretty printing for trait objects
Lukas Markeffsky committedFeb 7, 2024 Configuration menu - View commit details
-
Copy full SHA for 18e5bbf - Browse repository at this point
Copy the full SHA 18e5bbfView commit details -
address review comments and add more tests
Lukas Markeffsky committedFeb 7, 2024 Configuration menu - View commit details
-
Copy full SHA for c636c7a - Browse repository at this point
Copy the full SHA c636c7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 970f46c - Browse repository at this point
Copy the full SHA 970f46cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9dca6be - Browse repository at this point
Copy the full SHA 9dca6beView commit details
Commits on Feb 8, 2024
-
Add
SubdiagnosticMessageOp
as a trait alias.It avoids a lot of repetition.
Configuration menu - View commit details
-
Copy full SHA for 6b175a8 - Browse repository at this point
Copy the full SHA 6b175a8View commit details -
Rollup merge of rust-lang#119592 - petrochenkov:unload, r=compiler-er…
…rors resolve: Unload speculatively resolved crates before freezing cstore Name resolution sometimes loads additional crates to improve diagnostics (e.g. suggest imports). Not all of these diagnostics result in errors, sometimes they are just warnings, like in rust-lang#117772. If additional crates loaded speculatively stay and gets listed by things like `query crates` then they may produce further errors like duplicated lang items, because lang items from speculatively loaded crates are as good as from non-speculatively loaded crates. They can probably do things like adding unintended impls from speculatively loaded crates to method resolution as well. The extra crates will also get into the crate's metadata as legitimate dependencies. In this PR I remove the speculative crates from cstore when name resolution is finished and cstore is frozen. This is better than e.g. filtering away speculative crates in `query crates` because things like `DefId`s referring to these crates and leaking to later compilation stages can produce ICEs much easier, allowing to detect them. The unloading could potentially be skipped if any errors were reported (to allow using `DefId`s from speculatively loaded crates for recovery), but I didn't do it in this PR because I haven't seen such cases of recovery. We can reconsider later if any relevant ICEs are reported. Unblocks rust-lang#117772.
Configuration menu - View commit details
-
Copy full SHA for 766182d - Browse repository at this point
Copy the full SHA 766182dView commit details -
Rollup merge of rust-lang#120103 - compiler-errors:concrete-afits, r=…
…oli-obk Make it so that async-fn-in-trait is compatible with a concrete future in implementation There's no technical reason why an AFIT like `async fn foo()` cannot be satisfied with an implementation signature like `fn foo() -> Pin<Box<dyn Future<Output = ()> + 'static>>`. We rejected this previously because we were uncertain about how AFITs worked with refinement, but I don't believe this needs to be a restriction any longer. r? oli-obk
Configuration menu - View commit details
-
Copy full SHA for 8b5cf7c - Browse repository at this point
Copy the full SHA 8b5cf7cView commit details -
Rollup merge of rust-lang#120206 - petrochenkov:somehir, r=compiler-e…
…rrors hir: Make sure all `HirId`s have corresponding HIR `Node`s And then remove `tcx.opt_hir_node(hir_id)` in favor of `tcx.hir_node(hir_id)`.
Configuration menu - View commit details
-
Copy full SHA for e0086b4 - Browse repository at this point
Copy the full SHA e0086b4View commit details -
Rollup merge of rust-lang#120214 - Nadrieril:fix-120210, r=pnkfelix
match lowering: consistently lower bindings deepest-first Currently when lowering match expressions to MIR, we do a funny little dance with the order of bindings. I attempt to explain it in the third commit: we handle refutable (i.e. needing a test) patterns differently than irrefutable ones. This leads to inconsistencies, as reported in rust-lang#120210. The reason we need a dance at all is for situations like: ```rust fn foo1(x: NonCopyStruct) { let y @ NonCopyStruct { copy_field: z } = x; // the above should turn into let z = x.copy_field; let y = x; } ``` Here the `y ``````@``````` binding will move out of `x`, so we need to copy the field first. I believe that the inconsistency came about when we fixed rust-lang#69971, and didn't notice that the fix didn't extend to refutable patterns. My guess then is that ordering bindings by "deepest-first, otherwise source order" is a sound choice. This PR implements that (at least I hope, match lowering is hard to follow 🥲). Fixes rust-lang#120210 r? ``````@oli-obk`````` since you merged the original fix to rust-lang#69971 cc ``````@matthewjasper``````
Configuration menu - View commit details
-
Copy full SHA for fd8bc48 - Browse repository at this point
Copy the full SHA fd8bc48View commit details -
Rollup merge of rust-lang#120596 - GuillaumeGomez:jump-to-def-non-loc…
…al-link, r=notriddle [rustdoc] Correctly generate path for non-local items in source code pages While browsing some crates using the "jump to def" feature, I realized that a lot of items didn't have a link generated. The reason is because we only cache foreign items if they appear in the documented API. This means that for the others, we need to infer them. r? ``@notriddle``
Configuration menu - View commit details
-
Copy full SHA for 16cf13f - Browse repository at this point
Copy the full SHA 16cf13fView commit details -
Rollup merge of rust-lang#120688 - cjgillot:gvn-partial-move, r=oli-obk
GVN: also turn moves into copies with projections Fixes rust-lang#120613
Configuration menu - View commit details
-
Copy full SHA for 491b6c2 - Browse repository at this point
Copy the full SHA 491b6c2View commit details -
Rollup merge of rust-lang#120727 - Nadrieril:tweak-int-reporting, r=c…
…ompiler-errors exhaustiveness: Prefer "`0..MAX` not covered" to "`_` not covered" There was an exception when reporting integer ranges as missing, it's been there for as long as I can remember. This PR removes it. I think it's nicer to report "`0..MAX` not covered" than "`_` not covered". This also makes it consistent with enums, where we report individual enum variants in this case (as showcased in the rest of the `empty-match.rs` test). r? `@estebank`
Configuration menu - View commit details
-
Copy full SHA for a7847bb - Browse repository at this point
Copy the full SHA a7847bbView commit details -
Rollup merge of rust-lang#120734 - nnethercote:SubdiagnosticMessageOp…
…, r=compiler-errors Add `SubdiagnosticMessageOp` as a trait alias. It avoids a lot of repetition. r? matthewjasper
Configuration menu - View commit details
-
Copy full SHA for e19ffa1 - Browse repository at this point
Copy the full SHA e19ffa1View commit details -
Rollup merge of rust-lang#120739 - lukas-code:pp-dyn-assoc, r=compile…
…r-errors improve pretty printing for associated items in trait objects * Don't print a binder in front of associated items, because it's not valid syntax. * e.g. print `dyn for<'a> Trait<'a, Assoc = &'a u8>` instead of `dyn for<'a> Trait<'a, for<'a> Assoc = &'a u8>`. * Don't print associated items that are implied by a supertrait bound. * e.g. if we have `trait Sub: Super<Assoc = u8> {}`, then just print `dyn Sub` instead of `dyn Sub<Assoc = u8>`. I've added the test in the first commit, so you can see the diff of the compiler output in the second commit.
Configuration menu - View commit details
-
Copy full SHA for cc12a53 - Browse repository at this point
Copy the full SHA cc12a53View commit details