Ignore less tests in debug builds #121531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @compiler-errors. Use r? to explicitly pick a reviewer |
rustbot
added
A-testsuite
compiler-errors
approved these changes
Feb 24, 2024
|
@bors r+ rollup |
|
🌲 The tree is currently closed for pull requests below priority 50. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 24, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#121435 (Account for RPITIT in E0310 explicit lifetime constraint suggestion) - rust-lang#121490 (Rustdoc: include crate name in links for local primitives) - rust-lang#121520 (delay cloning of iterator items) - rust-lang#121522 (check that simd_insert/extract indices are in-bounds) - rust-lang#121531 (Ignore less tests in debug builds) - rust-lang#121539 (compiler/rustc_target/src/spec/base/apple/tests.rs: Avoid unnecessary large move) - rust-lang#121542 (update stdarch) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 24, 2024
Rollup merge of rust-lang#121531 - saethlin:ignore-less-debug, r=compiler-errors Ignore less tests in debug builds Since rust-lang#120594 and rust-lang#120863, nearly all UB-detecting debug assertions get compiled out of code that is monomorphized by a crate built with debug assertions disabled. Which means that if we default all our codegen tests to `-Cdebug-assertions=no`, most of them work just fine against a sysroot built with debug assertions. I also tried to explain a bit better why some tests need to be skipped, for those that still need to be skipped.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 23, 2024
…=Mark-Simulacrum Enable more mir-opt tests in debug builds This is rust-lang#121531 but for the mir-opt test suite.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 23, 2024
…=Mark-Simulacrum Enable more mir-opt tests in debug builds This is rust-lang#121531 but for the mir-opt test suite.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 23, 2024
…=Mark-Simulacrum Enable more mir-opt tests in debug builds This is rust-lang#121531 but for the mir-opt test suite.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 23, 2024
Rollup merge of rust-lang#122921 - saethlin:mir-opt-tests-in-debug, r=Mark-Simulacrum Enable more mir-opt tests in debug builds This is rust-lang#121531 but for the mir-opt test suite.
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Mar 24, 2024
…ulacrum Enable more mir-opt tests in debug builds This is rust-lang/rust#121531 but for the mir-opt test suite.
RenjiSann
pushed a commit
to RenjiSann/rust
that referenced
this pull request
Mar 25, 2024
…=Mark-Simulacrum Enable more mir-opt tests in debug builds This is rust-lang#121531 but for the mir-opt test suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #120594 and #120863, nearly all UB-detecting debug assertions get compiled out of code that is monomorphized by a crate built with debug assertions disabled.
Which means that if we default all our codegen tests to
-Cdebug-assertions=no, most of them work just fine against a sysroot built with debug assertions.I also tried to explain a bit better why some tests need to be skipped, for those that still need to be skipped.