Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Box::into_raw: make Miri understand that this is a box-to-raw cast #124013

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Box::into_raw: make Miri understand that this is a box-to-raw cast #124013

merged 1 commit into from
Apr 17, 2024

Conversation

RalfJung
Copy link
Member

Turns out #122647 went a bit too far in cleaning up Box... we still need a hack in Box::into_raw. The nicer fix would be to make Stacked Borrows not care about reference-to-raw-pointer casts, but it's unclear whether that will ever be possible without going to full Tree Borrows.

Fixes rust-lang/miri#3473.

@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2024

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 16, 2024
@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2024

The Miri subtree was changed

cc @rust-lang/miri

@oli-obk
Copy link
Contributor

oli-obk commented Apr 16, 2024

r? @oli-obk

@bors r+

@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2024

oli-obk has insufficient capacity to be assigned the pull request at this time. PR assignment has been reverted.

Please choose another assignee.

(see documentation)

@bors
Copy link
Contributor

bors commented Apr 16, 2024

📌 Commit 8606efa has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2024
@apiraino
Copy link
Contributor

r? @oli-obk

@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2024

Could not assign reviewer from: oli-obk.
User(s) oli-obk are either the PR author, already assigned, or on vacation. If it's a team, we could not find any candidates.
Please use r? to specify someone else to assign.

@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2024

oli-obk has insufficient capacity to be assigned the pull request at this time. PR assignment has been reverted.

Please choose another assignee.

(see documentation)

@apiraino
Copy link
Contributor

r? @lqd

@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2024

Could not assign reviewer from: lqd.
User(s) lqd are either the PR author, already assigned, or on vacation. If it's a team, we could not find any candidates.
Please use r? to specify someone else to assign.

@apiraino apiraino assigned lqd and unassigned jhpratt Apr 16, 2024
@rustbot rustbot unassigned lqd Apr 16, 2024
@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2024

lqd has insufficient capacity to be assigned the pull request at this time. PR assignment has been reverted.

Please choose another assignee.

(see documentation)

@apiraino apiraino self-assigned this Apr 16, 2024
@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2024

apiraino has insufficient capacity to be assigned the pull request at this time. PR assignment has been reverted.

Please choose another assignee.

(see documentation)

@apiraino
Copy link
Contributor

r? @oli-obk

@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2024

Could not assign reviewer from: oli-obk.
User(s) oli-obk are either the PR author, already assigned, or on vacation. If it's a team, we could not find any candidates.
Please use r? to specify someone else to assign.

@apiraino
Copy link
Contributor

r? @oli-obk

@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2024

Could not assign reviewer from: oli-obk.
User(s) oli-obk are either the PR author, already assigned, or on vacation. If it's a team, we could not find any candidates.
Please use r? to specify someone else to assign.

@apiraino
Copy link
Contributor

r? @oli-obk

@RalfJung
Copy link
Member Author

I'll unsubscribe, please ping me if the PR needs work.

This was referenced Apr 16, 2024
Merged
Merged
@apiraino
Copy link
Contributor

r? @apiraino

@rustbot rustbot assigned apiraino and unassigned oli-obk Apr 16, 2024
@apiraino apiraino removed their assignment Apr 16, 2024
@apiraino
Copy link
Contributor

r? @apiraino

@apiraino apiraino assigned oli-obk and unassigned apiraino Apr 16, 2024
@GuillaumeGomez GuillaumeGomez mentioned this pull request Apr 16, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 17, 2024
@bors
Auto merge of rust-lang#124040 - GuillaumeGomez:rollup-hrrvsgh, r=Gui…
7e3ba5b 
…llaumeGomez

Rollup of 7 pull requests

Successful merges:

 - rust-lang#123673 (Don't ICE for kind mismatches during error rendering)
 - rust-lang#123675 (Taint const qualifs if a static is referenced that didn't pass wfcheck)
 - rust-lang#123975 (Port the 2 `rust-lld` run-make tests to `rmake`)
 - rust-lang#124000 (Use `/* value */` as a placeholder)
 - rust-lang#124013 (Box::into_raw: make Miri understand that this is a box-to-raw cast)
 - rust-lang#124027 (Prefer identity equality over equating types during coercion.)
 - rust-lang#124036 (Remove `default_hidden_visibility: false` from wasm targets)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 51cfa95 into rust-lang:master Apr 17, 2024
12 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 17, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 17, 2024
@rust-timer
Unrolled build for rust-lang#124013
4b7a5f0 
Rollup merge of rust-lang#124013 - RalfJung:box-to-raw, r=oli-obk

Box::into_raw: make Miri understand that this is a box-to-raw cast

Turns out rust-lang#122647 went a bit too far in cleaning up `Box`... we still need a hack in `Box::into_raw`. The nicer fix would be to make Stacked Borrows not care about reference-to-raw-pointer casts, but it's unclear whether that will ever be possible without going to full Tree Borrows.

Fixes rust-lang/miri#3473.
@RalfJung RalfJung deleted the box-to-raw branch April 17, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.

Box::into_raw no longer does proper retag-to-raw
7 participants
@RalfJung @rustbot @oli-obk @bors @apiraino @lqd @jhpratt