Directly add extension instead of using Path::with_extension
#125406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Nadrieril rustbot has assigned @Nadrieril. Use |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
tbu-
force-pushed
the
pr_rm_path_with_extension
branch
from
70d39cd
to
87b77a2
Compare
|
Good spot! @bors r+ rollup |
bors
added
S-waiting-on-bors
fmease
added a commit
to fmease/rust
that referenced
this pull request
May 22, 2024
…Nadrieril Directly add extension instead of using `Path::with_extension` `Path::with_extension` has a nice footgun when the original path doesn't contain an extension: Anything after the last dot gets removed.
fmease
added a commit
to fmease/rust
that referenced
this pull request
May 22, 2024
…Nadrieril Directly add extension instead of using `Path::with_extension` `Path::with_extension` has a nice footgun when the original path doesn't contain an extension: Anything after the last dot gets removed.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 22, 2024
Rollup of 7 pull requests Successful merges: - rust-lang#122665 (Add some tests for public-private dependencies.) - rust-lang#125210 (Cleanup: Fix up some diagnostics) - rust-lang#125316 (Tweak `Spacing` use) - rust-lang#125401 (Migrate `run-make/rustdoc-scrape-examples-macros` to `rmake.rs`) - rust-lang#125406 (Directly add extension instead of using `Path::with_extension`) - rust-lang#125409 (Rename `FrameworkOnlyWindows` to `RawDylibOnlyWindows`) - rust-lang#125416 (Use correct param-env in `MissingCopyImplementations`) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 23, 2024
Rollup of 7 pull requests Successful merges: - rust-lang#122665 (Add some tests for public-private dependencies.) - rust-lang#125210 (Cleanup: Fix up some diagnostics) - rust-lang#125316 (Tweak `Spacing` use) - rust-lang#125401 (Migrate `run-make/rustdoc-scrape-examples-macros` to `rmake.rs`) - rust-lang#125406 (Directly add extension instead of using `Path::with_extension`) - rust-lang#125409 (Rename `FrameworkOnlyWindows` to `RawDylibOnlyWindows`) - rust-lang#125416 (Use correct param-env in `MissingCopyImplementations`) r? `@ghost` `@rustbot` modify labels: rollup
|
@bors rollup=iffy |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 23, 2024
…drieril Directly add extension instead of using `Path::with_extension` `Path::with_extension` has a nice footgun when the original path doesn't contain an extension: Anything after the last dot gets removed.
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
tbu-
force-pushed
the
pr_rm_path_with_extension
branch
from
87b77a2
to
0a3ecea
Compare
Interesting. This was apparently already hit by the existing code, because the added suffix just got dropped entirely. ^^ |
|
Do you think that might have been intentional? |
I don't think so. There's no point in adding a suffix that is immediately removed again. The |
|
Alright, let's try again @bors r+ |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 29, 2024
…drieril Directly add extension instead of using `Path::with_extension` `Path::with_extension` has a nice footgun when the original path doesn't contain an extension: Anything after the last dot gets removed.
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
sync @bors r- |
bors
added
S-waiting-on-author
|
The test failure is due to formatting, I'm surprised that tidy didn't catch it. Anyway, please run |
`Path::with_extension` has a nice footgun when the original path doesn't contain an extension: Anything after the last dot gets removed.
tbu-
force-pushed
the
pr_rm_path_with_extension
branch
from
0a3ecea
to
f7c51a2
Compare
|
Autoformatted. @rustbot ready |
rustbot
added
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (67caf52): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 3.6%, secondary 4.4%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 672.761s -> 670.655s (-0.31%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Path::with_extensionhas a nice footgun when the original path doesn't contain an extension: Anything after the last dot gets removed.