Expand `avx512_target_feature` to include VEX variants #126617

sayantn · 2024-06-18T07:37:45Z

Added 5 new target features for x86:

AVX-IFMA
AVX-NE-CONVERT
AVX-VNNI
AVX-VNNI_INT8
AVX-VNNI_INT16

Both LLVM and GCC already have support for these.

rustbot · 2024-06-18T07:37:53Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Nadrieril (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

compiler/rustc_target/src/target_features.rs

Nadrieril · 2024-06-18T09:07:07Z

r? @workingjubilee

Urgau · 2024-06-18T12:05:47Z

The job x86_64-gnu-llvm-17 failed! Check out the build log: (web) (plain)

Regarding this failure, you need to "bless" the test outputs, since they change with your PR.
I would recommend using: ./x.py test --stage 1 tests/ui/check-cfg/ --bless and commit the changes.

rustbot · 2024-06-18T19:25:01Z

Some changes occurred in tests/ui/check-cfg

cc @Urgau

tests/ui/check-cfg/well-known-values.stderr

workingjubilee · 2024-06-18T20:57:17Z

@sayantn Can you squash the first two commits? No need to have an add-then-remove in the same PR.

sayantn · 2024-06-20T06:42:26Z

@workingjubilee the commits have been merged

workingjubilee · 2024-06-20T20:18:31Z

Thanks!
@bors r+

bors · 2024-06-20T20:18:34Z

📌 Commit 1e1b3fc has been approved by workingjubilee

It is now in the queue for this repository.

Expand `avx512_target_feature` to include VEX variants Added 5 new target features for x86: - `AVX-IFMA` - `AVX-NE-CONVERT` - `AVX-VNNI` - `AVX-VNNI_INT8` - `AVX-VNNI_INT16` Both LLVM and GCC already have support for these. See also the [stdarch PR](rust-lang/stdarch#1586)

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#125627 (migration lint for `expr2024` for the edition 2024) - rust-lang#126481 (Add `powerpc-unknown-openbsd` maintaince status) - rust-lang#126613 (Print the tested value in int_log tests) - rust-lang#126617 (Expand `avx512_target_feature` to include VEX variants) - rust-lang#126686 (Add `#[rustc_dump_{predicates,item_bounds}]`) - rust-lang#126700 (Make edition dependent `:expr` macro fragment act like the edition-dependent `:pat` fragment does) - rust-lang#126707 (Pass target to inaccessible-temp-dir rmake test) - rust-lang#126757 (Properly gate `safe` keyword in pre-expansion) r? `@ghost` `@rustbot` modify labels: rollup

Expand `avx512_target_feature` to include VEX variants Added 5 new target features for x86: - `AVX-IFMA` - `AVX-NE-CONVERT` - `AVX-VNNI` - `AVX-VNNI_INT8` - `AVX-VNNI_INT16` Both LLVM and GCC already have support for these. See also the [stdarch PR](rust-lang/stdarch#1586)

…kingjubilee Rollup of 9 pull requests Successful merges: - rust-lang#124101 (Add PidFd::{kill, wait, try_wait}) - rust-lang#126125 (Improve conflict marker recovery) - rust-lang#126481 (Add `powerpc-unknown-openbsd` maintaince status) - rust-lang#126613 (Print the tested value in int_log tests) - rust-lang#126617 (Expand `avx512_target_feature` to include VEX variants) - rust-lang#126707 (Pass target to inaccessible-temp-dir rmake test) - rust-lang#126712 (Migrate `relocation-model`, `error-writing-dependencies` and `crate-name-priority` `run-make` tests to rmake) - rust-lang#126757 (Properly gate `safe` keyword in pre-expansion) - rust-lang#126758 (Do not allow safe/unsafe on static and fn items) r? `@ghost` `@rustbot` modify labels: rollup

Expand `avx512_target_feature` to include VEX variants Added 5 new target features for x86: - `AVX-IFMA` - `AVX-NE-CONVERT` - `AVX-VNNI` - `AVX-VNNI_INT8` - `AVX-VNNI_INT16` Both LLVM and GCC already have support for these. See also the [stdarch PR](rust-lang/stdarch#1586)

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#124101 (Add PidFd::{kill, wait, try_wait}) - rust-lang#126125 (Improve conflict marker recovery) - rust-lang#126481 (Add `powerpc-unknown-openbsd` maintenance status) - rust-lang#126613 (Print the tested value in int_log tests) - rust-lang#126617 (Expand `avx512_target_feature` to include VEX variants) - rust-lang#126700 (Make edition dependent `:expr` macro fragment act like the edition-dependent `:pat` fragment does) - rust-lang#126707 (Pass target to inaccessible-temp-dir rmake test) - rust-lang#126767 (`StaticForeignItem` and `StaticItem` are the same) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#126125 (Improve conflict marker recovery) - rust-lang#126481 (Add `powerpc-unknown-openbsd` maintenance status) - rust-lang#126613 (Print the tested value in int_log tests) - rust-lang#126617 (Expand `avx512_target_feature` to include VEX variants) - rust-lang#126700 (Make edition dependent `:expr` macro fragment act like the edition-dependent `:pat` fragment does) - rust-lang#126707 (Pass target to inaccessible-temp-dir rmake test) - rust-lang#126767 (`StaticForeignItem` and `StaticItem` are the same) - rust-lang#126774 (Fix another assertion failure for some Expect diagnostics.) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#126617 - sayantn:veorq, r=workingjubilee Expand `avx512_target_feature` to include VEX variants Added 5 new target features for x86: - `AVX-IFMA` - `AVX-NE-CONVERT` - `AVX-VNNI` - `AVX-VNNI_INT8` - `AVX-VNNI_INT16` Both LLVM and GCC already have support for these. See also the [stdarch PR](rust-lang/stdarch#1586)

rustbot assigned Nadrieril Jun 18, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 18, 2024

sayantn mentioned this pull request Jun 18, 2024

Runtime detection of VEX variants of AVX512 rust-lang/stdarch#1586

Merged

workingjubilee requested changes Jun 18, 2024

View reviewed changes

compiler/rustc_target/src/target_features.rs Outdated Show resolved Hide resolved

compiler/rustc_target/src/target_features.rs Show resolved Hide resolved

workingjubilee reviewed Jun 18, 2024

View reviewed changes

compiler/rustc_target/src/target_features.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

rustbot assigned workingjubilee and unassigned Nadrieril Jun 18, 2024

sayantn requested a review from workingjubilee June 18, 2024 10:47

This comment has been minimized.

Sign in to view

workingjubilee reviewed Jun 18, 2024

View reviewed changes

tests/ui/check-cfg/well-known-values.stderr Show resolved Hide resolved

workingjubilee changed the title ~~Add Some new target features for x86~~ Expand avx512_target_feature to include VEX variants Jun 18, 2024

workingjubilee approved these changes Jun 18, 2024

View reviewed changes

sayantn and others added 2 commits June 19, 2024 11:19

Add the target-features

b6d20d1

Fix stderr cases

1e1b3fc

sayantn force-pushed the veorq branch from 353364c to 1e1b3fc Compare June 19, 2024 05:54

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2024

matthiaskrgr mentioned this pull request Jun 20, 2024

Rollup of 8 pull requests #126760

Closed

workingjubilee mentioned this pull request Jun 20, 2024

Tracking Issue for AVX512 intrinsics #111137

Open

2 tasks

workingjubilee mentioned this pull request Jun 21, 2024

Rollup of 9 pull requests #126771

Closed

matthiaskrgr mentioned this pull request Jun 21, 2024

Rollup of 8 pull requests #126775

Closed

matthiaskrgr mentioned this pull request Jun 21, 2024

Rollup of 8 pull requests #126781

Merged

bors merged commit 2b7f6e2 into rust-lang:master Jun 21, 2024
6 checks passed

rustbot added this to the 1.81.0 milestone Jun 21, 2024

sayantn deleted the veorq branch June 25, 2024 05:19

workingjubilee added the O-x86_64 Target: x86-64 processors (like x86_64-*) label Jul 14, 2024

sayantn mentioned this pull request Sep 14, 2024

cpufeatures: requesting support for the newly added target features RustCrypto/utils#1112

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expand `avx512_target_feature` to include VEX variants #126617

Expand `avx512_target_feature` to include VEX variants #126617

sayantn commented Jun 18, 2024 •

edited

Loading

rustbot commented Jun 18, 2024

This comment has been minimized.

Nadrieril commented Jun 18, 2024

This comment has been minimized.

Urgau commented Jun 18, 2024

rustbot commented Jun 18, 2024

workingjubilee commented Jun 18, 2024

sayantn commented Jun 20, 2024

workingjubilee commented Jun 20, 2024

bors commented Jun 20, 2024

Expand avx512_target_feature to include VEX variants #126617

Expand avx512_target_feature to include VEX variants #126617

Conversation

sayantn commented Jun 18, 2024 • edited Loading

rustbot commented Jun 18, 2024

This comment has been minimized.

Nadrieril commented Jun 18, 2024

This comment has been minimized.

Urgau commented Jun 18, 2024

rustbot commented Jun 18, 2024

workingjubilee commented Jun 18, 2024

sayantn commented Jun 20, 2024

workingjubilee commented Jun 20, 2024

bors commented Jun 20, 2024

Expand `avx512_target_feature` to include VEX variants #126617

Expand `avx512_target_feature` to include VEX variants #126617

sayantn commented Jun 18, 2024 •

edited

Loading