ensure std step before preparing sysroot #128108
Conversation
rustbot
added
S-waiting-on-review
There was a problem hiding this comment.
I'm always super confused by these various steps (Rustc, Sysroot, etc.) and which are needed for an actually working sysroot :)
What also confuses me that x build is not enough by itself, I need e.g. x build library or x build sysroot. Tested this locally, it works, thank you!
However, is it possible that this regressed rustdoc caching? On master, if I delete the build directory and do x build with download-rustc = true, rustdoc is not rebuild. With this PR, if I do the same, rustdoc is rebuilt.
When using download-rustc, any stage other than 0 or 1 (e.g., cargo +stage2 build/doc) will fail to find std while compiling on simple rust sources. Ensuring the rustc step fixes this issue. Signed-off-by: onur-ozkan <work@onurozkan.dev>
onur-ozkan
force-pushed
the
ensure-std-for-precompiled-rustc
branch
from
9a56efa
to
2f55ced
Compare
onur-ozkan
changed the title
|
With the latest commit, the @bors r+ rollup |
bors
added
S-waiting-on-bors
|
Ah, nice! I did observe this regression (dunno when this regressed tho) and wanted to document it here: rust-lang/rustc-dev-guide#1917. I guess I can close it now :) |
|
Could you describe the regression in more detail? Did you use download-rustc? |
|
Yeah, I suppose I did use download-rustc – indirectly that is — via |
|
I see. |
…led-rustc, r=Kobzol ensure std step before preparing sysroot When using download-rustc, any stage other than 0 or 1 (e.g., cargo +stage2 build/doc) will fail to find std while compiling on simple rust sources. Ensuring the std step fixes this issue. r? Kobzol
…led-rustc, r=Kobzol ensure std step before preparing sysroot When using download-rustc, any stage other than 0 or 1 (e.g., cargo +stage2 build/doc) will fail to find std while compiling on simple rust sources. Ensuring the std step fixes this issue. r? Kobzol
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#124895 (Disallow hidden references to mutable static) - rust-lang#128043 (Docs for core::primitive: mention that "core" can be shadowed, too, so we should write "::core") - rust-lang#128092 (Remove wrapper functions from c.rs) - rust-lang#128100 (Allow to pass a full path for `run-make` tests) - rust-lang#128106 (Fix return type of FileAttr methods on AIX target) - rust-lang#128108 (ensure std step before preparing sysroot) r? `@ghost` `@rustbot` modify labels: rollup
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#125962 (Update tracking issue for `const_binary_heap_new_in`) - rust-lang#126770 (Add elem_offset and related methods) - rust-lang#127481 (Remove generic lifetime parameter of trait `Pattern`) - rust-lang#128043 (Docs for core::primitive: mention that "core" can be shadowed, too, so we should write "::core") - rust-lang#128092 (Remove wrapper functions from c.rs) - rust-lang#128100 (Allow to pass a full path for `run-make` tests) - rust-lang#128106 (Fix return type of FileAttr methods on AIX target) - rust-lang#128108 (ensure std step before preparing sysroot) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#128108 - onur-ozkan:ensure-std-for-precompiled-rustc, r=Kobzol ensure std step before preparing sysroot When using download-rustc, any stage other than 0 or 1 (e.g., cargo +stage2 build/doc) will fail to find std while compiling on simple rust sources. Ensuring the std step fixes this issue. r? Kobzol
When using download-rustc, any stage other than 0 or 1 (e.g., cargo +stage2 build/doc) will fail to find std while compiling on simple rust sources. Ensuring the std step fixes this issue.
r? Kobzol