Enable msvc for run-make/rust-lld #128656

ChrisDenton · 2024-08-04T16:41:56Z

This is simply a matter of using the right argument for lld-link.

As a bonus, I also fixed a typo.

try-job: i686-msvc
try-job: x86_64-msvc

rustbot · 2024-08-04T16:42:02Z

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-08-04T16:42:04Z

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

ChrisDenton · 2024-08-04T16:44:50Z

@bors try

lqd · 2024-08-04T16:45:30Z

I don’t remember we’ve implemented self-contained linking other than by using a c/c++ compiler driver link-arg, while msvc needs to change the linker, so it’ll be interesting to see the results.

Enable msvc for run-make/rust-lld This is simply a matter of using the right argument for lld-link. As a bonus, I also fixed a typo. try-job: i686-msvc try-job: x86_64-msvc

bors · 2024-08-04T16:45:59Z

⌛ Trying commit d6c9d64 with merge b3c6a51...

lqd · 2024-08-04T16:47:59Z

r=me if it works tho

bors · 2024-08-04T18:31:44Z

☀️ Try build successful - checks-actions
Build commit: b3c6a51 (b3c6a51bf4fc2dfe811fc51a542e6ba065f6043b)

ChrisDenton · 2024-08-04T18:32:12Z

Success!

@bors r=lqd rollup

bors · 2024-08-04T18:32:15Z

📌 Commit d6c9d64 has been approved by lqd

It is now in the queue for this repository.

lqd · 2024-08-04T19:51:51Z

Ah I think I know why it works even though we didn’t purposefully implement self-contained linking on non-unixy platforms: we can change the linker according to the linker flavor, and we currently use an lld linker-flavor as an implementation detail of self-contained linking. I guess this test will prevent us from being lazy when we refactor this away 😅 .

Enable msvc for run-make/rust-lld This is simply a matter of using the right argument for lld-link. As a bonus, I also fixed a typo. try-job: i686-msvc try-job: x86_64-msvc

…enton Rollup of 11 pull requests Successful merges: - rust-lang#128026 (std::thread: available_parallelism implementation for vxWorks proposal.) - rust-lang#128471 (rustdoc: Fix handling of `Self` type in search index and refactor its representation) - rust-lang#128607 (Use `object` in `run-make/symbols-visibility`) - rust-lang#128609 (Remove unnecessary constants from flt2dec dragon) - rust-lang#128611 (run-make: Remove cygpath) - rust-lang#128630 (docs(resolve): more explain about `target`) - rust-lang#128638 (run-make: enable msvc for `link-dedup`) - rust-lang#128647 (Enable msvc for link-args-order) - rust-lang#128649 (run-make: Enable msvc for `no-duplicate-libs` and `zero-extend-abi-param-passing`) - rust-lang#128656 (Enable msvc for run-make/rust-lld) - rust-lang#128660 (tests: more crashes) r? `@ghost` `@rustbot` modify labels: rollup

ChrisDenton · 2024-08-05T04:33:53Z

Failed in rollup... on Apple??? Huh.

#128668 (comment)

ChrisDenton · 2024-08-05T04:35:15Z

tests/run-make/rust-lld/rmake.rs


 fn main() {
+    // lld-link is used if msvc, otherwise a gnu-compatible lld is used.
+    let linker_version_flag = if is_msvc() { "--version" } else { "Wl,-v" };


Oh, I made a typo of my own. I forgot the dash -. Silly me.

ChrisDenton · 2024-08-05T04:38:02Z

@bors r-

This is simply a matter of using the right argument for lld-link.

ChrisDenton · 2024-08-05T04:40:34Z

Let's try that again...

@bors r=lqd

bors · 2024-08-05T04:40:37Z

📌 Commit 1737845 has been approved by lqd

It is now in the queue for this repository.

Enable msvc for run-make/rust-lld This is simply a matter of using the right argument for lld-link. As a bonus, I also fixed a typo. try-job: i686-msvc try-job: x86_64-msvc

Rollup of 8 pull requests Successful merges: - rust-lang#122049 (Promote riscv64gc-unknown-linux-musl to tier 2) - rust-lang#125558 (Tweak type inference for `const` operands in inline asm) - rust-lang#128638 (run-make: enable msvc for `link-dedup`) - rust-lang#128647 (Enable msvc for link-args-order) - rust-lang#128649 (run-make: Enable msvc for `no-duplicate-libs` and `zero-extend-abi-param-passing`) - rust-lang#128656 (Enable msvc for run-make/rust-lld) - rust-lang#128688 (custom MIR: add support for tail calls) - rust-lang#128691 (Update `compiler-builtins` to 0.1.115) r? `@ghost` `@rustbot` modify labels: rollup

Enable msvc for run-make/rust-lld This is simply a matter of using the right argument for lld-link. As a bonus, I also fixed a typo. try-job: i686-msvc try-job: x86_64-msvc

Rollup of 7 pull requests Successful merges: - rust-lang#128206 (Make create_dll_import_lib easier to implement) - rust-lang#128221 (Add implied target features to target_feature attribute) - rust-lang#128384 (Add tests to ensure MTE tags are preserved across FFI boundaries) - rust-lang#128656 (Enable msvc for run-make/rust-lld) - rust-lang#128691 (Update `compiler-builtins` to 0.1.117) - rust-lang#128700 (Migrate `simd-ffi` `run-make` test to rmake) - rust-lang#128758 (Specify a minimum supported version for VxWorks) r? `@ghost` `@rustbot` modify labels: rollup

…llaumeGomez Rollup of 9 pull requests Successful merges: - rust-lang#128206 (Make create_dll_import_lib easier to implement) - rust-lang#128424 (minor `effects` cleanups) - rust-lang#128527 (More information for fully-qualified suggestion when there are multiple impls) - rust-lang#128656 (Enable msvc for run-make/rust-lld) - rust-lang#128683 (bootstrap: clear miri's ui test deps when rustc changes) - rust-lang#128700 (Migrate `simd-ffi` `run-make` test to rmake) - rust-lang#128753 (Don't arbitrarily choose one upper bound for hidden captured region error message) - rust-lang#128757 (Migrate `pgo-gen-lto` `run-make` test to rmake) - rust-lang#128758 (Specify a minimum supported version for VxWorks) Failed merges: - rust-lang#128679 (codegen: better centralize function declaration attribute computation) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#128656 - ChrisDenton:rust-lld, r=lqd Enable msvc for run-make/rust-lld This is simply a matter of using the right argument for lld-link. As a bonus, I also fixed a typo. try-job: i686-msvc try-job: x86_64-msvc

rustbot assigned jieyouxu Aug 4, 2024

rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2024

ChrisDenton mentioned this pull request Aug 4, 2024

run-make: audit the ignore-{windows,msvc,windows-msvc} tests #128602

Open

28 tasks

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2024

ChrisDenton mentioned this pull request Aug 5, 2024

Rollup of 11 pull requests #128668

Closed

ChrisDenton commented Aug 5, 2024

View reviewed changes

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 5, 2024

Enable msvc for run-make/rust-lld

1737845

This is simply a matter of using the right argument for lld-link.

ChrisDenton force-pushed the rust-lld branch from d6c9d64 to 1737845 Compare August 5, 2024 04:39

bors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 5, 2024

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 5, 2024

tgross35 mentioned this pull request Aug 5, 2024

Rollup of 8 pull requests #128698

Closed

tgross35 mentioned this pull request Aug 7, 2024

Rollup of 6 pull requests #128765

Closed

tgross35 mentioned this pull request Aug 7, 2024

Rollup of 9 pull requests #128767

Closed

tgross35 mentioned this pull request Aug 7, 2024

Rollup of 8 pull requests #128770

Closed

tgross35 mentioned this pull request Aug 7, 2024

Rollup of 7 pull requests #128773

Closed

GuillaumeGomez mentioned this pull request Aug 7, 2024

Rollup of 9 pull requests #128783

Merged

bors merged commit a05f187 into rust-lang:master Aug 7, 2024
6 checks passed

rustbot added this to the 1.82.0 milestone Aug 7, 2024

ChrisDenton deleted the rust-lld branch August 7, 2024 16:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable msvc for run-make/rust-lld #128656

Enable msvc for run-make/rust-lld #128656

ChrisDenton commented Aug 4, 2024

rustbot commented Aug 4, 2024

rustbot commented Aug 4, 2024

ChrisDenton commented Aug 4, 2024

lqd commented Aug 4, 2024

bors commented Aug 4, 2024

lqd commented Aug 4, 2024

bors commented Aug 4, 2024

ChrisDenton commented Aug 4, 2024

bors commented Aug 4, 2024

lqd commented Aug 4, 2024

ChrisDenton commented Aug 5, 2024 •

edited

Loading

ChrisDenton Aug 5, 2024 •

edited

Loading

ChrisDenton commented Aug 5, 2024

ChrisDenton commented Aug 5, 2024

bors commented Aug 5, 2024

Enable msvc for run-make/rust-lld #128656

Enable msvc for run-make/rust-lld #128656

Conversation

ChrisDenton commented Aug 4, 2024

rustbot commented Aug 4, 2024

rustbot commented Aug 4, 2024

ChrisDenton commented Aug 4, 2024

lqd commented Aug 4, 2024

bors commented Aug 4, 2024

lqd commented Aug 4, 2024

bors commented Aug 4, 2024

ChrisDenton commented Aug 4, 2024

bors commented Aug 4, 2024

lqd commented Aug 4, 2024

ChrisDenton commented Aug 5, 2024 • edited Loading

ChrisDenton Aug 5, 2024 • edited Loading

Choose a reason for hiding this comment

ChrisDenton commented Aug 5, 2024

ChrisDenton commented Aug 5, 2024

bors commented Aug 5, 2024

ChrisDenton commented Aug 5, 2024 •

edited

Loading

ChrisDenton Aug 5, 2024 •

edited

Loading