Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify DestProp memory management #129720

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Simplify DestProp memory management #129720

merged 4 commits into from
Sep 5, 2024

Commits on Aug 29, 2024

  1. Remove the 'body lifetime on FilterInformation. 

    It's not needed.
    @nnethercote
    nnethercote committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    c6111c0 View commit details
    Browse the repository at this point in the history

  2. Move WriteInfo out of Allocations. 

    It doesn't need to be in there, and the move simplifies lifetimes.
    @nnethercote
    nnethercote committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    0a282ea View commit details
    Browse the repository at this point in the history

  3. Remove Allocations. 

    It's not necessary, and just complicates things.
    @nnethercote
    nnethercote committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    ad5a6e1 View commit details
    Browse the repository at this point in the history

  4. Simplify Candidate. 

    By making it own the index maps, instead of holding references to them.
This requires moving the free function `find_candidate` into
`Candidate::reset_and_find`. It lets the `'alloc` lifetime be removed
everywhere that still has it.
    @nnethercote
    nnethercote committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    1be2204 View commit details
    Browse the repository at this point in the history