-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support char::encode_utf8
in const scenarios.
#130511
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ibraheemdev (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
This comment has been minimized.
This comment has been minimized.
Checks complain about missing stability attribute but I'm not sure what version I should point it to. |
|
r? libs-api |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Should |
This comment has been minimized.
This comment has been minimized.
I wouldn't say so - methods like Also (once your code passes tests) you should squash your commits into one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
118a3fc
to
fb475e4
Compare
@bors r+ |
… r=dtolnay Support `char::encode_utf8` in const scenarios. This PR implements [`rust-lang/rfcs#3696`](rust-lang/rfcs#3696). This assumes [`const_slice_from_raw_parts_mut`](rust-lang#67456).
…kingjubilee Rollup of 3 pull requests Successful merges: - rust-lang#129755 (test: cross-edition metavar fragment specifiers) - rust-lang#130511 (Support `char::encode_utf8` in const scenarios.) - rust-lang#130531 (Check params for unsafety in THIR) r? `@ghost` `@rustbot` modify labels: rollup
☀️ Test successful - checks-actions |
Finished benchmarking commit (f8192ba): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary 0.9%, secondary -1.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary 3.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResults (primary 0.0%, secondary 0.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 767.849s -> 769.07s (0.16%) |
@rustbot label: +perf-regression-triaged |
This PR implements
rust-lang/rfcs#3696
.This assumes
const_slice_from_raw_parts_mut
.