Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump cc dependency #130898

Closed
wants to merge 1 commit into from
Closed

Bump cc dependency #130898

wants to merge 1 commit into from

Conversation

arttet
Copy link
Contributor

@arttet arttet commented Sep 26, 2024 •
edited
Loading

We cannot merge the PR
Let's try merging an older version for a change.

#130720 (comment)
#130908 (comment)
#130908

try-job: x86_64-msvc

@rustbot
Copy link
Collaborator

rustbot commented Sep 26, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 26, 2024
@rustbot
Copy link
Collaborator

rustbot commented Sep 26, 2024

These commits modify the library/Cargo.lock file. Unintentional changes to library/Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@arttet
Copy link
Contributor Author

arttet commented Sep 26, 2024

CC: @tgross35 @ChrisDenton

@arttet
Copy link
Contributor Author

arttet commented Sep 26, 2024

r? @tgross35

@rustbot rustbot assigned tgross35 and unassigned Mark-Simulacrum Sep 26, 2024
@tgross35
Copy link
Contributor

Could you add a fixme for the = pin?

@arttet
Copy link
Contributor Author

arttet commented Sep 26, 2024 •
edited
Loading

Could you please clarify your question?
You mean

cc = "=1.0.106" # FIXME:

Right?

@tgross35
Copy link
Contributor

Just something to note it is meant to be temporary, in case this winds up merging:

# FIXME: updates past a certain point haven't been able to merge successfully.
# See rust-lang/rust#130720.
cc = "=1.0.106"

We can start a try job to at least get some feedback without waiting on the queue. (feel free to push whenever with the fixme comment, that won't stop the job)

@bors try

@bors
Copy link
Contributor

bors commented Sep 26, 2024

⌛ Trying commit 02d045e with merge 13a134a...

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 26, 2024
@bors
Auto merge of rust-lang#130898 - arttet:test/cc, r=<try>
13a134a 
Bump cc dependency

We cannot merge the [PR](rust-lang#130720)
Let's try merging an older version for a change.

rust-lang#130720 (comment)

try-job: x86_64-msvc
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@tgross35
Copy link
Contributor

@bors try

@tgross35
Copy link
Contributor

tgross35 commented Sep 26, 2024 •
edited
Loading

If it fails again, could you try the smallest possible bump to 1.0.100?

If that still doesn't work, I guess maybe this bump somehow invalidates cached C builds...? Seems unlikely.

@bors
Copy link
Contributor

bors commented Sep 26, 2024

⌛ Trying commit 4c98033 with merge ea47bea...

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 26, 2024
@bors
Auto merge of rust-lang#130898 - arttet:test/cc, r=<try>
ea47bea 
Bump cc dependency

We cannot merge the [PR](rust-lang#130720)
Let's try merging an older version for a change.

rust-lang#130720 (comment)

try-job: x86_64-msvc
@workingjubilee
Copy link
Member

@bors rollup=iffy

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Sep 26, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 26, 2024
This was referenced Sep 26, 2024
Merged
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 26, 2024
@bors
Auto merge of rust-lang#130908 - tgross35:update-cc, r=<try>
f42fb94 
[experiment] Update cc to 1.0.100

See rust-lang#130720, rust-lang#130898; try with the minimal version bump.

try-job: x86_64-msvc
@tgross35
Copy link
Contributor

Will try one more time with this version, opened #130908 to try 1.0.100 in parallel.

@bors try

@bors
Copy link
Contributor

bors commented Sep 26, 2024

⌛ Trying commit 4c98033 with merge 83e023e...

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 26, 2024
@bors
Auto merge of rust-lang#130898 - arttet:test/cc, r=<try>
83e023e 
Bump cc dependency

We cannot merge the [PR](rust-lang#130720)
Let's try merging an older version for a change.

rust-lang#130720 (comment)

try-job: x86_64-msvc
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Sep 27, 2024

💔 Test failed - checks-actions

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
@bors
Auto merge of rust-lang#130908 - tgross35:update-cc, r=<try>
9d55780 
[experiment] Update cc to 1.0.100

See rust-lang#130720, rust-lang#130898; try with the minimal version bump.

try-job: x86_64-msvc
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
@bors
Auto merge of rust-lang#130908 - tgross35:update-cc, r=<try>
ed664a2 
[experiment] Update cc to 1.0.100

See rust-lang#130720, rust-lang#130898; try with the minimal version bump.

try-job: x86_64-msvc
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
@bors
Auto merge of rust-lang#130908 - tgross35:update-cc, r=<try>
f1d03b0 
[experiment] Update cc to 1.0.100

See rust-lang#130720, rust-lang#130898; try with the minimal version bump.

try-job: x86_64-msvc
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
@bors
Auto merge of rust-lang#130908 - tgross35:update-cc, r=<try>
3bfb192 
[experiment] Update `cc` CI tests

See rust-lang#130720, rust-lang#130898; try with the minimal version bump.

try-job: x86_64-msvc
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
@bors
Auto merge of rust-lang#130908 - tgross35:update-cc, r=<try>
61e52cc 
[experiment] Update `cc` CI tests

See rust-lang#130720, rust-lang#130898; try with the minimal version bump.

try-job: x86_64-msvc
@arttet
Copy link
Contributor Author

arttet commented Sep 27, 2024

@bors try

@bors
Copy link
Contributor

bors commented Sep 27, 2024

@arttet: 🔑 Insufficient privileges: not in try users

@arttet
Copy link
Contributor Author

arttet commented Sep 27, 2024

Can I get the try permission for this PR?

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
@bors
Auto merge of rust-lang#130908 - tgross35:update-cc, r=<try>
d82723e 
[experiment] Update `cc` CI tests

See rust-lang#130720, rust-lang#130898; try with the minimal version bump.

try-job: x86_64-msvc
@arttet arttet closed this Sep 27, 2024
@arttet arttet deleted the test/cc branch September 27, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tgross35 tgross35

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@arttet @rustbot @tgross35 @bors @rust-log-analyzer @workingjubilee @Mark-Simulacrum