Stabilize 5 const_mut_refs-dependent API
#131177
Merged
+21
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Const-stabilizes: - `str::from_utf8_unchecked_mut`
Const-stabilizes: - `str::as_bytes_mut` - `str::as_mut_ptr`
Const-stabilizes: - `NonNull::as_mut`
Const-stabilizes: - `UnsafeCell::get_mut`
Const-stabilizes: - `slice::first_mut` - `slice::split_first_mut` - `slice::last_mut` - `slice::split_last_mut`
rustbot
added
S-waiting-on-review
tgross35
added
the
S-waiting-on-fcp
|
Extracted from #130954 due to that one turning out to need a T-lang FCP for some features. |
|
FCPs completed at:
There are no changes here besides updating the @bors r+ |
bors
added
S-waiting-on-bors
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Oct 4, 2024
…-referees, r=tgross35 Stabilize 5 `const_mut_refs`-dependent API Since `const_mut_refs` and `const_refs_to_cell` have been stabilized, we now may create mutable references inside our library API. Thus we now stabilize the `const fn` version of these public library APIs which required such in their implementation: - const `NonNull::as_mut` rust-lang#91822 (comment) - const `slice::{first,last}_mut`: rust-lang#83570 (comment) - const `str::as_{mut_ptr,bytes_mut}`: rust-lang#130086 (comment) - const `str::from_utf8_unchecked_mut`: rust-lang#91005 (comment) - const `UnsafeCell::get_mut`: rust-lang#88836 (comment)
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Oct 4, 2024
…-referees, r=tgross35 Stabilize 5 `const_mut_refs`-dependent API Since `const_mut_refs` and `const_refs_to_cell` have been stabilized, we now may create mutable references inside our library API. Thus we now stabilize the `const fn` version of these public library APIs which required such in their implementation: - const `NonNull::as_mut` rust-lang#91822 (comment) - const `slice::{first,last}_mut`: rust-lang#83570 (comment) - const `str::as_{mut_ptr,bytes_mut}`: rust-lang#130086 (comment) - const `str::from_utf8_unchecked_mut`: rust-lang#91005 (comment) - const `UnsafeCell::get_mut`: rust-lang#88836 (comment)
This was referenced Oct 4, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 4, 2024
…kingjubilee Rollup of 10 pull requests Successful merges: - rust-lang#130453 (Add x86_64-unknown-trusty as tier 3 target) - rust-lang#130518 (Stabilize the `map`/`value` methods on `ControlFlow`) - rust-lang#131116 (Increase Stack Size for AIX) - rust-lang#131171 (Fix `target_env` in `avr-unknown-gnu-atmega328`) - rust-lang#131174 (Fix `target_abi` in `sparc-unknown-none-elf`) - rust-lang#131177 ( Stabilize 5 `const_mut_refs`-dependent API) - rust-lang#131238 (Remove mw from triagebot.toml) - rust-lang#131240 (Fix typo in csky-unknown-linux-gnuabiv2.md) - rust-lang#131257 ([rustdoc] Fix list margins) - rust-lang#131264 (Fix some `pub(crate)` that were undetected bc of `#[instrument]`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 5, 2024
Rollup merge of rust-lang#131177 - workingjubilee:stabilize-const-mut-referees, r=tgross35 Stabilize 5 `const_mut_refs`-dependent API Since `const_mut_refs` and `const_refs_to_cell` have been stabilized, we now may create mutable references inside our library API. Thus we now stabilize the `const fn` version of these public library APIs which required such in their implementation: - const `NonNull::as_mut` rust-lang#91822 (comment) - const `slice::{first,last}_mut`: rust-lang#83570 (comment) - const `str::as_{mut_ptr,bytes_mut}`: rust-lang#130086 (comment) - const `str::from_utf8_unchecked_mut`: rust-lang#91005 (comment) - const `UnsafeCell::get_mut`: rust-lang#88836 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
const_mut_refsandconst_refs_to_cellhave been stabilized, we now may create mutable references inside our library API. Thus we now stabilize theconst fnversion of these public library APIs which required such in their implementation:NonNull::as_mutTracking Issue forconst_ptr_as_ref#91822 (comment)slice::{first,last}_mut: Tracking Issue for#![feature(const_slice_first_last)]#83570 (comment)str::as_{mut_ptr,bytes_mut}: Tracking Issue for const_str_as_mut #130086 (comment)str::from_utf8_unchecked_mut: Tracking Issue forstr::from_utf8_unchecked_mutas aconst fn#91005 (comment)UnsafeCell::get_mut: Tracking Issue for#![feature(const_unsafecell_get_mut)]#88836 (comment)#![feature(const_slice_first_last)]#83570#![feature(const_unsafecell_get_mut)]#88836str::from_utf8_unchecked_mutas aconst fn#91005const_ptr_as_ref#91822