Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When generating WF criteria, do not visit the same type more than once #23013

Merged
merged 1 commit into from
Mar 6, 2015

Conversation

nikomatsakis
Copy link
Contributor

When generating WF criteria, do not visit the same type more than once. Fixes an infinite stack overflow (#23003).

r? @aturon

@pnkfelix
Copy link
Member

pnkfelix commented Mar 4, 2015

@bors r=8c28284 rollup

@bors
Copy link
Contributor

bors commented Mar 4, 2015

🙀 rollup is not a valid commit SHA. Please try again with 8c28284.

@pnkfelix
Copy link
Member

pnkfelix commented Mar 4, 2015

@bors r+ 8c28284 rollup

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 4, 2015
 When generating WF criteria, do not visit the same type more than once. Fixes an infinite stack overflow (rust-lang#23003).

r? @aturon
@nagisa
Copy link
Member

nagisa commented Mar 4, 2015

Does this fix #12644, #22375 or #21946 as well?

@nikomatsakis
Copy link
Contributor Author

@nagisa I don't know, those look a bit different, but I suspect they are fixed by either this or #23026

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 5, 2015
 When generating WF criteria, do not visit the same type more than once. Fixes an infinite stack overflow (rust-lang#23003).

r? @aturon
@bors bors merged commit 8c28284 into rust-lang:master Mar 6, 2015
@nikomatsakis nikomatsakis deleted the syncbox branch March 30, 2016 16:17
@c410-f3r c410-f3r mentioned this pull request Dec 22, 2022
Noratrieb added a commit to Noratrieb/rust that referenced this pull request Dec 23, 2022
Move tests

r? `@petrochenkov`

* 6470 is an ancient LLVM compilation bug
* 22375 to typeck because of rust-lang#23013
Noratrieb added a commit to Noratrieb/rust that referenced this pull request Dec 23, 2022
Move tests

r? ``@petrochenkov``

* 6470 is an ancient LLVM compilation bug
* 22375 to typeck because of rust-lang#23013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants