Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of PRs in the queue; Wednesday #23473

Merged
merged 13 commits into from
Mar 18, 2015
Merged

Conversation

Manishearth
Copy link
Member

No description provided.

WiSaGaN and others added 6 commits March 15, 2015 21:42
Very minor fix: in `std::net::Ipv6Addr::new`, the documentation had an incomplete representation of the resulting address, missing the last two groups.
The alignment field is actually a "pointer sized" type instead of always i64,
requiring that the size of the padding field is also calculated slightly
differently.

Closes rust-lang#23425
This commit clarifies some of the unstable features in the `str` module by
moving them out of the blanket `core` and `collections` features.

The following methods were moved to the `str_char` feature which generally
encompasses decoding specific characters from a `str` and dealing with the
result. It is unclear if any of these methods need to be stabilized for 1.0 and
the most conservative route for now is to continue providing them but to leave
them as unstable under a more specific name.

* `is_char_boundary`
* `char_at`
* `char_range_at`
* `char_at_reverse`
* `char_range_at_reverse`
* `slice_shift_char`

The following methods were moved into the generic `unicode` feature as they are
specifically enabled by the `unicode` crate itself.

* `nfd_chars`
* `nfkd_chars`
* `nfc_chars`
* `graphemes`
* `grapheme_indices`
* `width`
Closes rust-lang#23451.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@Manishearth
Copy link
Member Author

@bors: r+ p=20

@bors
Copy link
Contributor

bors commented Mar 18, 2015

📌 Commit 8827f9b has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Mar 18, 2015

⌛ Testing commit 8827f9b with merge 31694ba...

@bors
Copy link
Contributor

bors commented Mar 18, 2015

💔 Test failed - auto-mac-64-nopt-t

@Manishearth Manishearth changed the title Rollup or PRs in the queue; Wednesday Rollup of PRs in the queue; Wednesday Mar 18, 2015
@Manishearth
Copy link
Member Author

@bors: r+ p=20 force

@bors
Copy link
Contributor

bors commented Mar 18, 2015

📌 Commit e4ac4a4 has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Mar 18, 2015

⌛ Testing commit e4ac4a4 with merge 61b416d...

@bors
Copy link
Contributor

bors commented Mar 18, 2015

💔 Test failed - auto-win-64-opt

@Manishearth
Copy link
Member Author

@bors: r+ p=20 force

@bors
Copy link
Contributor

bors commented Mar 18, 2015

📌 Commit baf7f18 has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Mar 18, 2015

⌛ Testing commit baf7f18 with merge 1608432...

@bors
Copy link
Contributor

bors commented Mar 18, 2015

💔 Test failed - auto-win-64-opt

@Manishearth
Copy link
Member Author

@bors: r+ p=20

@bors
Copy link
Contributor

bors commented Mar 18, 2015

📌 Commit 2a106d6 has been approved by Manishearth

@Manishearth
Copy link
Member Author

@bors: force

@bors
Copy link
Contributor

bors commented Mar 18, 2015

⌛ Testing commit 2a106d6 with merge 15bcda8...

 This commit clarifies some of the unstable features in the `str` module by
moving them out of the blanket `core` and `collections` features.

The following methods were moved to the `str_char` feature which generally
encompasses decoding specific characters from a `str` and dealing with the
result. It is unclear if any of these methods need to be stabilized for 1.0 and
the most conservative route for now is to continue providing them but to leave
them as unstable under a more specific name.

* `is_char_boundary`
* `char_at`
* `char_range_at`
* `char_at_reverse`
* `char_range_at_reverse`
* `slice_shift_char`

The following methods were moved into the generic `unicode` feature as they are
specifically enabled by the `unicode` crate itself.

* `nfd_chars`
* `nfkd_chars`
* `nfc_chars`
* `graphemes`
* `grapheme_indices`
* `width`
…r=Manishearth

 Since module `std::sync::mpsc` is stable now, fix the deprecated link `comm` with `sync::mpsc`.
…x, r=steveklabnik

 Very minor fix: in `std::net::Ipv6Addr::new`, the documentation had an incomplete representation of the resulting address, missing the last two groups.
…r=brson

 The alignment field is actually a \"pointer sized\" type instead of always i64,
requiring that the size of the padding field is also calculated slightly
differently.

Closes rust-lang#23425
 I often have to run `ast-json` or look into the pretty-printer source to figure out what the fields of an AST enum mean. I've tried to document most of what I know (and some semi-obvious stuff).

r? @steveklabnik

f? @eddyb
@alexcrichton
Copy link
Member

@bors: retry force

@bors
Copy link
Contributor

bors commented Mar 18, 2015

⌛ Testing commit 2a106d6 with merge 94a9506...

@alexcrichton
Copy link
Member

@bors falls again to the iron will of @Manishearth!

@Manishearth Manishearth deleted the rollup branch March 18, 2015 23:20
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants