Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace zeroing-on-drop with filling-on-drop. #23535

Merged
merged 9 commits into from
Mar 28, 2015

Commits on Mar 26, 2015

  1. Switch drop-flag to u8 to allow special tags to instrument state.

    Refactored code so that the drop-flag values for initialized
    (`DTOR_NEEDED`) versus dropped (`DTOR_DONE`) are given explicit names.
    
    Add `mem::dropped()` (which with `DTOR_DONE == 0` is semantically the
    same as `mem::zeroed`, but the point is that it abstracts away from
    the particular choice of value for `DTOR_DONE`).
    
    Filling-drop needs to use something other than `ptr::read_and_zero`,
    so I added such a function: `ptr::read_and_drop`.  But, libraries
    should not use it if they can otherwise avoid it.
    
    Fixes to tests to accommodate filling-drop.
    pnkfelix committed Mar 26, 2015
    Configuration menu
    Copy the full SHA
    3902190 View commit details
    Browse the repository at this point in the history
  2. Regression tests for issues uncovered only post the run-pass and comp…

    …ile-fail tests.
    
    (I.e. the idea being, lets catch errors in these basic constructs
    sometime *before* we start doing the doc tests.)
    pnkfelix committed Mar 26, 2015
    Configuration menu
    Copy the full SHA
    7c671e5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5bc35b1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5733726 View commit details
    Browse the repository at this point in the history
  5. Added instability markers to POST_DROP_* consts, and related opt-in's.

    (Reviewed rest of code; did not see other `pub` items that needed such
    treatment.)
    
    Driveby: fix typo in comment in ptr.rs.
    pnkfelix committed Mar 26, 2015
    Configuration menu
    Copy the full SHA
    601eca3 View commit details
    Browse the repository at this point in the history
  6. Use -Z force-dropflag-checks=on/off for emitting sanity-check.

    (That is, added config and debugflag a la check-overflow but for drop
    flag sanity-check.)
    
    Remove now-unused import of NoDebugInfo from trans::glue.
    pnkfelix committed Mar 26, 2015
    Configuration menu
    Copy the full SHA
    4053b00 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    aab4bef View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    e2cc8b1 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2015

  1. Configuration menu
    Copy the full SHA
    b68ca84 View commit details
    Browse the repository at this point in the history