Validate the formatting of extended errors. #24458
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -20,6 +20,9 @@ use parse::token; | |||
| use ptr::P; | |||
| use util::small_vector::SmallVector; | |||
|
|
|||
| // Maximum width of any line in an extended error description (inclusive). | |||
| static MAX_DESCRIPTION_WIDTH: usize = 80; | |||
There was a problem hiding this comment.
This probably makes more sense as a const (we care about the value itself, not the memory location).
|
@huonw: Fixed. |
|
@bors r+ |
|
📌 Commit c17e78c has been approved by |
|
☔ The latest upstream changes (presumably #24512) made this pull request unmergeable. Please resolve the merge conflicts. |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Apr 17, 2015
I've updated the diagnostic registration plugin so that it validates error descriptions. An error description is only valid if it starts and ends with a newline, and contains no more than 80 characters per line. The plugin forced me to fix E0005 and E0006 which had escaped manual attention! I've also added errors for E0267, E0268, E0296, whilst updating E0303 as per discussion in rust-lang#24143. cc rust-lang#24407
|
@Manishearth: I was fixing this up with a rebase but it seems you have it covered? For the next batch of errors I could do one PR with everyone's commits? |
|
Sure; that would be nice. |
|
Closing in favor of the merged version at #24542 |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Apr 18, 2015
I did a manual merge of all the extended error PRs as we were getting merge conflicts yesterday. I think this is preferable to merging separately as I ended up having to manually merge @nham and @GuillaumeGomez's commits. Rollup of rust-lang#24458, rust-lang#24482 and rust-lang#24488. rust-lang#24482 and rust-lang#24488 were already re-approved, and would need to be cancelled if this is merged instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the diagnostic registration plugin so that it validates error descriptions. An error description is only valid if it starts and ends with a newline, and contains no more than 80 characters per line.
The plugin forced me to fix E0005 and E0006 which had escaped manual attention!
I've also added errors for E0267, E0268, E0296, whilst updating E0303 as per discussion in #24143.
cc #24407